Add a setting to allow users to set account-wide custom notification sound

[kenwuuu]

Signed-off-by: Ken Wu [email protected]

Issues Addressed

Custom notification issues

https://github.com/vector-im/element-web/issues/5891 https://github.com/vector-im/element-web/issues/20286 https://github.com/vector-im/element-web/issues/15023

Planned simple changes

I'll work on these separately (new PR) if someone with write access tells me that they'll get this PR through first. https://github.com/vector-im/element-web/issues/18392 https://github.com/vector-im/element-web/issues/20864

Changes

• extract NotificationSound.tsx component
• add NotificationSound.tsx to Notifications.tsx
• allow NotificationSound.tsx to set/get notification sound without roomId
• rename getSoundForRoom(), generalize function usage
• rename some unnecessarily short variable names

How to test

To upload

• clone, yarn start in root
• open localhost:8080
• click avatar at top left
• open Notifications
• upload sexy sound (no visual indicator of success)
• make a friend. wait for them to message you

Screenshot of change

---

Here's what your changelog entry will look like:

✨ Features

Add a setting to allow users to set account-wide custom notification sound for messages (https://github.com/matrix-org/matrix-react-sdk/pull/10494). Fixes https://github.com/vector-im/element-web/issues/5891; https://github.com/vector-im/element-web/issues/20286; https://github.com/vector-im/element-web/issues/15023. Contributed by @kenwuuu

Checklist

• [x] Tests written for new code (and old code if feasible)
• [ ] Linter and other CI checks pass
• [x] Sign-off given on the changes (see CONTRIBUTING.md)

---

This PR currently has none of the required changelog labels.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

[kenwuuu]

@Half-Shot @t3chguy @turt2live

Hey folks, just looking to get confirmation that this is a feature that we're willing to merge in if I finish it out. You can test it out yourself.

[ShadowJonathan]

@kenwuuu thank you a lot for making this PR, and taking the time to try to resolve this 💚

[joshuacheong]

@kenwuuu @robintown It has been months, I desperately need sound customization. It gives me anxiety to listen to this unholy notification and causes unnecessary stress especially on a weekend.

[claell]

Product apparently gave feedback on the general feature. But not here 🥲.

See https://github.com/vector-im/element-web/issues/5891#issuecomment-1582316875

@daniellekirkwood @kongo09

Also note, that you said:

Instead we're spending our time focussed on bugs such as stuck notifications, accessibility, timeline jumpiness, etc.

But this doesn't make sense. This one is an accessibility bug to users, apparently. Some even say "health" affecting (not sure about that). So if you work on accessibility, here you go, this is an important accessibility problem, which is additionally easy to provide with a quick fix for now, that can then perfected in later work 🙂.

[dbkr]

With apologies to all those who are desperately wanting a way to change the sound, I'm going to close this PR: this isn't necessarily to say that we don't want the feature, but this one isn't in a mergeable state and hasn't been updated in over a year. If someone were motivated enough, they could extract the changes and make a fresh PR.

[joshuacheong]

I've disabled the sound and accepted that I would never use this messaging application and protocol for emergencies. Unfortunate but a reality.