matrix-js-sdk
matrix-js-sdk copied to clipboard
matrix-org
Feat: Voice activity threshold
Adding voice activity detection feature
More information at https://github.com/vector-im/element-call/pull/492
T-Enhancement
This PR currently has none of the required changelog labels.
A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.
(click the wheel next to my name in the top right corner to re-request my review once ready, same for EC PR)
Sorry missed 2 of those, should be addressed now. Unless we have missed some more. Most are outdated, which means we did work on it.
Just a few nitpicks, we're getting really close with this!
One more tiny nit: we tend to write comments with a space after the slashes (i.e.
// commentnot//comment)
No worries, changed the ones in the tests. Just so I don't make another new comment, I also put the audio delay on the same spot as the cooldown and treshold. This number works ofc, just not the node itself :P
LGTM now! Will also request Dave's review, just to be sure
Awesome!! One thing though: we likely need some human feedback on whether or not the settings like the cooldown and the quality are ok. I will try to personally test this out with friends, but more people would always be nice. (although I am behind a NAT with my low power server, so this will prob be a pain. Until now I have tested it locally.)
Is the intention to mass test this alongside other features in a hosted version of element-call?
LGTM now! Will also request Dave's review, just to be sure
Awesome!! One thing though: we likely need some human feedback on whether or not the settings like the cooldown and the quality are ok. I will try to personally test this out with friends, but more people would always be nice. (although I am behind a NAT with my low power server, so this will prob be a pain. Until now I have tested it locally.)
Is the intention to mass test this alongside other features in a hosted version of element-call?
Hmm, I think this would be best to discuss over at element-call with Jake since he's the one on the product team. Sorry, for late response...
Hmm, I think this would be best to discuss over at element-call with Jake since he's the one on the product team. Sorry, for late response...
No worries, also got lot's of stuff to do :P
I will see what causes the error, that ofc shouldn't happen. Is there anything specific that causes the error? Or just regular use?
As for why it is in an advanced tab. We were asked to do this:
