matrix-appservice-slack icon indicating copy to clipboard operation
matrix-appservice-slack copied to clipboard

Slack display names and avatars are no longer showing in Matrix

Open jejb opened this issue 2 years ago • 5 comments

Usually on slack messages, the avatars and display names show as clickable @displayname entries in element. Recently they started showing as 10 letter/number combinations instead.

So, for instance, on the CNCF Keylime slack, @stefan berger started showing as 01K5879MT2. This seems to be related to his slack expression on the bridge, which was @slack_cloud-native_U01K5879MT2:hansenpartnership.com on my hansenpartnership.com bridge.

This started happening some time between 24 and 30 September and didn't correspond to any upgrade I made to the slack bridge, so I think this is a protocol change on behalf of slack itself. Just in case, the slack bridge is installed directly from the github releases, and was version 1.8.0 eventually upgraded to 1.9.0 (with no impact to the problem). The synapse bridge is the default one coming with Debian Testing and is currently 1.44 but has been tracking releases fairly closely.

This problem is showing on both element-desktop and element android and seems to be consistent across several version upgrades.

jejb avatar Oct 21 '21 19:10 jejb

Interesting, I'll be curious to know if there are any logs about failed profile requests to Slack. We'll take a look our side too.

Half-Shot avatar Oct 21 '21 20:10 Half-Shot

~~I'm hoping https://github.com/matrix-org/matrix-appservice-slack/pull/628 will fix this~~ Nevermind, that's an opposite problem

tadzik avatar Oct 21 '21 21:10 tadzik

Fixed by https://github.com/matrix-org/matrix-appservice-slack/pull/631

Half-Shot avatar Oct 22 '21 15:10 Half-Shot

Actually, it doesn't seem to be fixed: I deployed the development version and tried a message in a channel I know to be failing. It's still showing the untranslated slack name. However, this time I caught a trace in the logs. The user it's failing to resolve is showing as 4RET4SNB

Oct 22 12:59:45 bedivere.hansenpartnership.com npm[689874]: Oct-22 12:59:45.211 INFO SlackGhost Updating user information for W4RET4SNB
Oct 22 12:59:45 bedivere.hansenpartnership.com npm[689874]: Oct-22 12:59:45.214 ERROR SlackGhost Failed to update ghost displayname: Error: At least one of displayname,avatarUrl must be defined
Oct 22 12:59:45 bedivere.hansenpartnership.com npm[689874]:     at Intent.ensureProfile (/var/lib/matrix-synapse/bridges/slack/matrix-appservice-slack/node_modules/matrix-appservice-bridge/lib/components/intent.js:584:19)
Oct 22 12:59:45 bedivere.hansenpartnership.com npm[689874]:     at SlackGhost.updateDisplayname (/var/lib/matrix-synapse/bridges/slack/matrix-appservice-slack/lib/SlackGhost.js:170:28)
Oct 22 12:59:45 bedivere.hansenpartnership.com npm[689874]:     at SlackGhost.update (/var/lib/matrix-synapse/bridges/slack/matrix-appservice-slack/lib/SlackGhost.js:98:24)
Oct 22 12:59:45 bedivere.hansenpartnership.com npm[689874]:     at BridgedRoom.onSlackMessage (/var/lib/matrix-synapse/bridges/slack/matrix-appservice-slack/lib/BridgedRoom.js:590:25)
Oct 22 12:59:45 bedivere.hansenpartnership.com npm[689874]:     at processTicksAndRejections (internal/process/task_queues.js:97:5)
Oct 22 12:59:45 bedivere.hansenpartnership.com npm[689874]:     at async SlackRTMHandler.handleEvent (/var/lib/matrix-synapse/bridges/slack/matrix-appservice-slack/lib/SlackEventHandler.js:99:17)
Oct 22 12:59:45 bedivere.hansenpartnership.com npm[689874]:     at async SlackRTMHandler.handle (/var/lib/matrix-synapse/bridges/slack/matrix-appservice-slack/lib/SlackEventHandler.js:52:17)
Oct 22 12:59:45 bedivere.hansenpartnership.com npm[689874]:     at async RTMClient.<anonymous> (/var/lib/matrix-synapse/bridges/slack/matrix-appservice-slack/lib/SlackRTMHandler.js:156:21)
Oct 22 12:59:45 bedivere.hansenpartnership.com npm[689874]: Oct-22 12:59:45.987 INFO bridge 127.0.0.1 - - [22/Oct/2021:16:59:45 +0000] "PUT /transactions/16098?access_token=<REDACTED> HTTP/1.1" 200 2 "-" "Synapse/1.44.0"

jejb avatar Oct 22 '21 17:10 jejb

This happens to EMS customers too (see Z 34931 )

rtanglao avatar Jul 18 '22 04:07 rtanglao