matrix-appservice-irc icon indicating copy to clipboard operation
matrix-appservice-irc copied to clipboard

Published 20 hours ago • verified publisher icon matrix-org

Changelock checker doesn't verify the validity of changelog entry type

Open tadzik opened this issue 2 years ago • 0 comments

Contribution guide says

A changelog filename should be ${GithubPRNumber}.{bugfix|misc|feature|doc|removal}

but we only check for the Github PR number, not for the changelog entry type. This caused a nuisance in https://github.com/matrix-org/matrix-appservice-irc/pull/1555 and required fixing in https://github.com/matrix-org/matrix-appservice-irc/pull/1682.

tadzik avatar Mar 22 '23 13:03 tadzik