matrix-appservice-discord icon indicating copy to clipboard operation
matrix-appservice-discord copied to clipboard

Excessive metadata messages (name changes) in the timeline

Open planetoryd opened this issue 1 year ago • 10 comments

#general:matrix.themelio.org

image

Apparently this room uses t2bot.io

planetoryd avatar Oct 20 '23 09:10 planetoryd

got this issue too. The bot even recognize people's name on different servers (also look at the iam.someone changed their name, at the bottom) metadata leaks image

hahahahacker2009 avatar Oct 21 '23 10:10 hahahahacker2009

This is a reflection of cultural difference. On Discord, nickname changes are free and only leave a temporary trace in the audit log. On Matrix, nickname changes leave a permanent trace in the timeline.

erkinalp avatar Oct 27 '23 07:10 erkinalp

The virtual account only need to change its name channel-specific, not changing the name globally. Broken implementation, maybe?

hahahahacker2009 avatar Oct 31 '23 08:10 hahahahacker2009

This looks like discord user name changes simply being reflected to matrix, which would be intended behavior. (If you don't want to see the name changes in the element client, there's a setting under "Settings > Preferences > Timeline" called "Show display name changes" that allows you to disable it) Otherwise, please describe the nature of the issue more in-depth, e.g. are any display names not consistent between discord and matrix?

Vyquos avatar Dec 03 '23 16:12 Vyquos

@Vyquos Excessive nickname changes make it slow to load the room on the matrix side, even if collapsed. Not a concern on the discord side as name changes are effectively free there.

erkinalp avatar Dec 03 '23 17:12 erkinalp

I see what you're getting at. I don't think the bridge is at fault here though - bridging all user name changes is exactly what it's supposed to do. Excessive user name changes may occur for non-bridged matrix users too though. I believe that matrix clients have to solve this problem of timeline loading efficiency rather than the bridge.

Vyquos avatar Dec 03 '23 17:12 Vyquos

bridging all user name changes is exactly what it's supposed to do.

Disagree. Just do not create all these useless events. Noone needs them. Waste of compute.

At Matrix's current state you are going to get terrible lags and worst user experience ever out of it.

Like, you have to send one HTTP request for each message deletion.

planetoryd avatar Dec 04 '23 12:12 planetoryd

Not sending these events would cause inconsistent usernames - do you have a proposal to handle this? Also, what do you mean by "you have to send one HTTP request for each message deletion"?

Vyquos avatar Dec 04 '23 14:12 Vyquos

Like, you have to send one HTTP request for each message deletion.

Deletion expectations do not match. It is impossible to bridge discord-side cheap traceless deletions to matrix.

erkinalp avatar Dec 04 '23 19:12 erkinalp

@Vyquos Matrix protocol requires one event for each deletion, whether they are sent with one POST request for each event I am not sure, but it seems so. When I delete a large number of messages it's just stuck. Absolutely hilarious.

planetoryd avatar Dec 26 '23 03:12 planetoryd