matrix-android-sdk icon indicating copy to clipboard operation
matrix-android-sdk copied to clipboard

Read receipts are not correctly updated in the room summary

Open devjeff opened this issue 5 years ago • 1 comments

I think, there is a bug in the method "org.matrix.androidsdk.data.Room#handleReceiptData"

The read receipt event id is only updated if the receiptData is created by my user. According to the comment in the method and my understanding this is wrong. The setReadReceiptEventId method should be called in the opposite case, i. e. when the receiptData is coming from a different user. Thus, the if statement:

if (isUpdated && TextUtils.equals(mMyUserId, receiptData.userId))

must be changed to:

if (isUpdated && !TextUtils.equals(mMyUserId, receiptData.userId))

devjeff avatar Feb 07 '20 15:02 devjeff

Probably a sync issue. I had a similar problem with handleReceiptData crashing on sync read receipts data cast.

https://github.com/AchrafAmil/matrix-android-sdk/commit/e9e4a35846b997a2de46f09480ec27697a9cf070

AchrafAmil avatar May 11 '20 13:05 AchrafAmil