Implement filtering

[babolivier]

trafficstars

This issue is tracking the progress of the implementation of filtering on the CS API. AFAIK @CromFr has already been working on implementing that on /sync. Will also need to be implemented on /messages when that endpoint itself gets implemented.

[CromFr]

Yay filters ! 🎉

My current filter-related PRs:

• #436 implements the use of filter objects when storing / retrieving them in the database
• #438 and #513 implements the filtering logic inside the event query functions (but uses default filters inside IncrementalSync/CompleteSync so the /sync behaviour is unchanged), respectively for state and account data events
• #388 (closed) was my first attempt at implementing the filtering logic, all in one huge and messy PR.

I should have in my local repo some branches for other event types, and the final IncrementalSync/CompleteSync implementation, but requires some additional work to be sane & clean.

[babolivier]

Thanks for the info! For the record, and for maximum clarity, this issue being created doesn't mean that filtering will be addressed immediately (it basically means that I needed an open issue to make a TODO comment that's referring to it in a PR I'm currently working on). Hopefully there'll soon be enough bandwidth to deal with it, though.

[kegsay]

Sytests:

    × Can request federation format via the filter
    × Check creating invalid filters returns 4xx

[kegsay]

@neilalexander did you do this in https://github.com/matrix-org/dendrite/pull/1721 ?

[neilalexander]

We have filtering in /sync but I don't think we have it in /messages yet.

[spaetz]

So, was that implemented by https://github.com/matrix-org/dendrite/pull/2347 and can be closed then?

[kegsay]

There are still 2 outstanding tests which are failing.

[kegsay]

Still failing.