dendrite icon indicating copy to clipboard operation
dendrite copied to clipboard

Implement `/_matrix/client/v1/rooms/{roomId}/threads` (I am being lazy so can someone finish off this for me?)

Open qwqtoday opened this issue 1 year ago • 5 comments

Signed-off-by: Leung Ho Ching <[email protected]>

Pull Request Checklist

qwqtoday avatar Jul 31 '24 05:07 qwqtoday

this pr doesn't need tests because it's obviously working

qwqtoday avatar Aug 09 '24 11:08 qwqtoday

It needs tests so when new features are added or refactored, it won't break, and other devs who submit different pull requests, don't have to test this feature each time they submit a new PR. Tests are for future stability, the current feature is obviously always working, because if it wouldn't work, the dev would spend more time on it. But when 10 other features are added, nobody wants to manually test this feature 10 times to avoid breaking it while implementing those new features.

notramo avatar Aug 14 '24 09:08 notramo

It needs tests so when new features are added or refactored, it won't break, and other devs who submit different pull requests, don't have to test this feature each time they submit a new PR. Tests are for future stability, the current feature is obviously always working, because if it wouldn't work, the dev would spend more time on it. But when 10 other features are added, nobody wants to manually test this feature 10 times to avoid breaking it while implementing those new features.

Sure I will do it later

qwqtoday avatar Aug 14 '24 10:08 qwqtoday

@S7evinK can you run the workflow to test it?

qwqtoday avatar Aug 15 '24 06:08 qwqtoday

Thanks for contributing to Dendrite!

The repo has been cloned into element-hq/dendrite and made the switch to AGPL as per https://matrix.org/blog/2023/11/06/future-of-synapse-dendrite/. For more information, feel free to read this and this

If you still wish to contribute under the new license, feel free to create a new PR over at element-hq/dendrite.

S7evinK avatar Nov 14 '24 12:11 S7evinK