dendrite icon indicating copy to clipboard operation
dendrite copied to clipboard

Use mautrix for tag events instead of deprecated matrix/go

Open dgrr opened this issue 1 year ago • 2 comments

The iOS crashes because dendrite is using an old framework that is deprecated. For reference look here. This PR just fixes this.

Signed-off-by: Dario <[email protected]>

dgrr avatar May 31 '24 20:05 dgrr

The Spec states order is a number in the range of 0-1, while the iOS SDK is using string. https://spec.matrix.org/latest/client-server-api/#mtag

So imo this should be fixed in the iOS SDK.

S7evinK avatar Jun 01 '24 09:06 S7evinK

The Spec states order is a number in the range of 0-1, while the iOS SDK is using string. https://spec.matrix.org/latest/client-server-api/#mtag

So imo this should be fixed in the iOS SDK.

Indeed, but the new library (mautrix) is also using a string or json.Number, so it might be serialized as string and used as a number. Probably because a valid value could be 0.0000004200000000000069, and the precision of decoding into a float32 might not be enough. Therefore the usage of strings.

I think the change is legit, but both libraries use string (or json.Number) to improve the precision of encoding/decoding the message.

dgrr avatar Jun 01 '24 12:06 dgrr

Well, sorry for that, but Element iOS is not spec conform.

S7evinK avatar Aug 23 '24 20:08 S7evinK