dendrite icon indicating copy to clipboard operation
dendrite copied to clipboard

Rate limiting affects server administrator

Open boogewooge opened this issue 2 years ago • 2 comments

Background information

  • Dendrite version or git SHA: 0.8.9
  • Monolith or Polylith?: Monolith
  • SQLite3 or Postgres?: Postgres
  • Running in Docker?: No
  • go version: 1.18.4
  • Client used (if applicable): Element Web/Desktop

In https://github.com/matrix-org/dendrite/issues/2589, where rate_limiting being enabled causes issues, a server administrator (more than one in fact) was also affected, though https://github.com/matrix-org/dendrite/blob/main/dendrite-sample.monolith.yaml#L182= indicates that shouldn't be the case.

boogewooge avatar Jul 22 '22 22:07 boogewooge

We need to ensure we're testing that exempt_user_ids are actually being exempted from the rate limiting code.

kegsay avatar Jul 29 '22 09:07 kegsay

The problem I'm seeing is that the endpoint doesn't require authentication, so we don't have a device we can check for admin/exempt users.

S7evinK avatar Aug 02 '22 15:08 S7evinK