Mattias Reichel

Results 112 comments of Mattias Reichel

> I guess it doesn't like to resolve bom versions for documentation dependencies Wouldn't `documentation platform(project(':grails-bom'))` add it?

> Wouldn't documentation platform(project(':grails-bom')) add it? > apparently so... done Did you push that change?

Could we put the version properties at the top of the pom, like in https://repo1.maven.org/maven2/org/springframework/boot/spring-boot-dependencies/3.3.4/spring-boot-dependencies-3.3.4.pom? (That's where the important information is)

Could we add `spring-boot.version` so it's possible to override that too? Does that make sense? ```groovy (dependencyVersions.collect { [ version:it.key.version, name: "${it.key.name}.version" ] } + pluginsAndProfiles + [name: 'spring-boot.version', version:...

Shouldn't all the modules in `grails-core.ROOT` also be in the bom? Otherwise you can't do this for example: `implementation 'org.grails:grails-web-url-mappings'`

``` org.junit.jupiter:junit-jupiter:api,engine:$junitVersion org.junit.platform:junit-platform-runner::$junitPlatformRunnerVersion ``` should be removed from the bom, they are already in the spring-boot bom and the versions mismatch so there is an error when running tests: `org.junit.platform.commons.JUnitException:...

> How/wheere are you getting an error running testts? I'm publishing this branch to mavenLocal and using it to build `grails-mail` for testing. With the junit versions in the `grails-bom`...

Great! Almost there, but now the plugins and profiles don't come out right in the `grails-bom` pom. ```xml ``` and ```xml 8.0.0-SNAPSHOT ... ```

> cleaned up and fixed. Now the `.version` suffix fell off the generated version property names (or maybe it was already like this, before the last commit) 😄 ```xml 3.3.4...

@codeconsole The versions don't come out right: ```xml org.grails grails-bootstrap ${7.0.0-SNAPSHOT} ```