mpu
mpu copied to clipboard
Excessive amout of logging
My job raised concerns about the excessive amount of logging done via the print_pids function (maybe related to the way we are utilizing this).
Made a one liner change (I have no idea what I am doing) so to be able to use dynamic debug to control whether/when logging happens.
$ cat dynamic_debug.patch
diff -r -u mpu-4cd11efbf0b9623c97fc1f977a4fa9495bfff1e3/src/mpu_ioctl.c mpu-4cd11efbf0b9623c97fc1f977a4fa9495bfff1e3.new/src/mpu_ioctl.c
--- mpu-4cd11efbf0b9623c97fc1f977a4fa9495bfff1e3/src/mpu_ioctl.c 2024-01-14 06:53:09.000000000 +0000
+++ mpu-4cd11efbf0b9623c97fc1f977a4fa9495bfff1e3.new/src/mpu_ioctl.c 2024-12-31 00:27:11.538669134 +0000
@@ -135,7 +135,7 @@
u32 i;
for (i = 0; i < cnt; i++, pids += off)
{
- printk(KERN_DEBUG "mpu: %s dump process pid %u\n", tag, *pids);
+ pr_debug("mpu: %s dump process pid %u\n", tag, *pids);
}
}