mplfinance icon indicating copy to clipboard operation
mplfinance copied to clipboard

Extending trend lines (`tlines`)

Open sumprain opened this issue 2 years ago • 4 comments

Hello Daniel,

Thanks a lot for such a useful package.

I have made an enhancement in the trend line construction (using tlines kwarg in plot function).

By adding kwargs extend_start and extend_end to tlines parameter, we can extend trend line by extend_start dates from the start date and extend_end dates from end date.

Regards

@sumprain

sumprain avatar Jun 14 '22 11:06 sumprain

@sumprain Suman- Thank you so much for contributing to mplfinance. This enhancement looks interesting and useful. I will try to make time this week to code review and test, to be able to merge and release.

In the meantime, would you be willing to please add one or two use-case examples to the very end of the using lines tutorial. That will be very helpful.

As long as this Pull Request continues to be open, any changes you push to sumprain:master will automatically be propagated from sumprain:master into this Pull Request.

All the best. --Daniel

DanielGoldfarb avatar Jun 14 '22 12:06 DanielGoldfarb

Thanks a lot @DanielGoldfarb . I will surely do the needful.

Regards.

sumprain avatar Jun 14 '22 12:06 sumprain

While preparing examples, I detected some anomaly in slope of trend line when show-nontrading days is false. I am correcting it and will pull request it. Thanks and Regards @sumprain

sumprain avatar Jun 15 '22 17:06 sumprain

Dear Daniel, I have corrected the anomalies and added use cases in using lines tutorials.

Thanks and Regards

@sumprain

sumprain avatar Jun 16 '22 16:06 sumprain