mplfinance icon indicating copy to clipboard operation
mplfinance copied to clipboard

Published 20 hours ago • verified publisher icon matplotlib

add use_column kwarg

Open Havelkao opened this issue 2 years ago • 2 comments

Hello, recently I came across this stack overflow question and thought I could help with the enhancement. I'm new to open source, so hopefully I didn't mess up anything ^^

Havelkao avatar May 08 '22 12:05 Havelkao

@Havelkao This looks good. Thank you for contributing.

I'm wondering if (in addition to type='line') if this should also apply to moving averages? Or perhaps it only applies to moving averages for type='line'? What are your thoughts?

DanielGoldfarb avatar May 09 '22 14:05 DanielGoldfarb

Hm, I see, I'm not that familiar with the codebase, but I guess there is no harm in including line_data in that _plot_mav call. I assume mavs are mostly used with candlestick type charts so no need to limit it only to type='line'. If it makes sense to you, I can add this change later this week.

Havelkao avatar May 10 '22 14:05 Havelkao