mplfinance
mplfinance copied to clipboard
matplotlib
Added labels for make_addplot function (lines,bars,scatter). Missing …for _mscatter function.
Its missing for the _mscatter function. I didn't understood very well the function (maybe if I spent more time on it I could). Tested on jupyter lab and worked fine. Hope this is useful for the community. :)
Status update: I am presently reviewing all outstanding pull requests. did some experimenting with labels in general beyond just what is in this PR (see https://github.com/DanielGoldfarb/mplfinance/tree/ppseverin). When we finish this enhancement for labels I want to be able to support not just addplot, but also mav and hlines, vlines, alines, and tlines. That should not be difficult, but will require a bit more coding and a lot of testing (and adding some examples to the examples folder). There are a couple of other PRs that will be quicker and easier to merge, so I'm going to do those first and come back to this later.
Status update: I am presently reviewing all outstanding pull requests. did some experimenting with labels in general beyond just what is in this PR (see https://github.com/DanielGoldfarb/mplfinance/tree/ppseverin). When we finish this enhancement for labels I want to be able to support not just
addplot, but alsomavandhlines,vlines,alines, andtlines. That should not be difficult, but will require a bit more coding and a lot of testing (and adding some examples to the examples folder). There are a couple of other PRs that will be quicker and easier to merge, so I'm going to do those first and come back to this later.
hello, thanks for all the work so far!
any progress on this labels PR? i am looking to contribute to get this PR completed.
let me know if there is anything that I can help with.
@alexpvpmindustry Thanks for your interesting in, and expression of gratitude for, mplfinance. Much appreciated!
Here's the status: I am solidly involved in another project at this time, and in preparing for JupyterCon (hope to see you there) so I will be giving minimal attention to mplfinance at least until towards the end of May.
That said, if you read through the conversion above, you can see where I have made several suggestions regarding the code. I've also pointed out where I think we should be going with labels, annotations, and legends, specifically with regard to for which aspects of mplfinance these things should be supported. (until now, there appears to be no movement on my suggestions).
If you would like to contribute, along the lines of the discussion and requests above, then I will be happy to review any contributions. (Keep in mind that it has been a while since this PR was first entered, and the trunk may have since migrated somewhat; so a fresh clone may be in order). Alternatively you can wait for me to make these changes, in which case it will most likely be the middle of June or later before it will be done. As mentioned above, a core part of this particular enhancement is complete testing to ensure no existing functionality has been broken.
@DanielGoldfarb i see! sorry, i wont be available for the jupytercon, sounds exciting tho. @ppseverin seems inactive for the past few months, so I think I'll clone his work and update it. ill also include your suggestions, keeping in mind the new state of the repo. if/when he/she comes back and if he chooses to, ill gladly let him continue.