matplotlib
patheffects.SimpleLineShadow calling non-existent get_foreground method from GraphicsContextBase
resolves #28793 : Replaced nonexistent get_foreground() method with get_rgb()
PR checklist
- [x] "closes #0000" is in the body of the PR description to link the related issue
- [x] new and changed code is tested
- [x] [n/a] Plotting related features are demonstrated in an example
- [x] [n/a] New Features and API Changes are noted with a directive and release note
- [x] [n/a] Documentation complies with general and docstring guidelines
@timhoffm Hi. Just wondering what else needs to get done before this fix can get merged.
Per our merge policy, we need two reviews. So this is waiting for a second core developer to approve.
Are you interested in writing a test? It looks like you have a test script in #28793, and it should be able to be turned into a figure comparison if you compare the path effect with directly plotting a line with the effective settings.
Are you interested in writing a test? It looks like you have a test script in #28793, and it should be able to be turned into a figure comparison if you compare the path effect with directly plotting a line with the effective settings.
Sure, that shouldn't be a problem
I marked the test as XFail because the '@check_figures_equal()' decorator only works for identical results. Here are screen captures of the diff.
I don't understand; the point of the test would be to confirm that the shadow is set the way you'd expect it to, and thus have equal figures.
I don't understand; the point of the test would be to confirm that the shadow is set the way you'd expect it to, and thus have equal figures.
I see what you mean. I changed it to plot a line with the alpha value instead for transparency.
