matplotlib icon indicating copy to clipboard operation
matplotlib copied to clipboard

Changing bar examples to tea and coffee

Open SourajitaDewasi opened this issue 3 years ago • 0 comments

PR Summary

PR Checklist

Tests and Styling

  • [ ] Has pytest style unit tests (and pytest passes). [N/A]
  • [ ] Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all). [N/A]

Documentation

  • [ ] New features are documented, with examples if plot related. [N/A]
  • [ ] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). [N/A]
  • [ ] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there). [N/A]
  • [ ] Documentation is sphinx and numpydoc compliant (the docs should build without error). [N/A]

cc: @jklymak

SourajitaDewasi avatar Aug 09 '22 18:08 SourajitaDewasi

This looks good, except for the flake8 error. However, would you also be willing to do the same for the stacked bars as well?

jklymak avatar Aug 12 '22 16:08 jklymak

I will complete for the flake8 error and the stacked bars example too by 15th August 2022 @jklymak

SourajitaDewasi avatar Aug 12 '22 19:08 SourajitaDewasi

How to resolve this issue of ci/circleci: docs. I am facing this issue in both:

  1. examples/lines_bars_and_markers/bar_label_demo.py
  2. examples/units/bar_unit_demo.py

Can someone please help me out here

SourajitaDewasi avatar Aug 17 '22 13:08 SourajitaDewasi

There is no problem in those files; the problem is you need to rebase your branch on current main.

QuLogic avatar Aug 17 '22 22:08 QuLogic

When complete, this closes https://github.com/matplotlib/matplotlib/issues/23352

scottshambaugh avatar Aug 18 '22 21:08 scottshambaugh

@SourajitaDewasi thanks and congratulations on your first contribution to Matplotlib! 🎉

We hope to see you again.

timhoffm avatar Aug 27 '22 07:08 timhoffm

Thank you so much. This was my first contribution ever and this made me more eager to do better in OpenSource. I really look forward to working and contributing more in Matplotlib :)

Thank you once again!!!

SourajitaDewasi avatar Aug 27 '22 10:08 SourajitaDewasi