ipympl icon indicating copy to clipboard operation
ipympl copied to clipboard

figure changes size at end of loop if drawn dynamically

Open lucainnocenti opened this issue 8 years ago • 15 comments

As per the title, consider the following snippet:

import time
import ipympl
import matplotlib.pyplot as plt

fig, ax = plt.subplots(1, 1, figsize=(5, 5))
data = []
plt.show()
for idx in range(4):
    data.append(idx ** 2)
    ax.clear()
    ax.plot(data)
    fig.canvas.draw()
    time.sleep(0.2)

and this is what I get running it:

gyrodown

I used plt.show() at the beginning of the loop because nothing gets drawn otherwise. Is there a way to avoid this?

lucainnocenti avatar Aug 21 '17 21:08 lucainnocenti

Do you have high-dpi display?

tacaswell avatar Aug 22 '17 02:08 tacaswell

I do, is that the problem?

lucainnocenti avatar Aug 22 '17 07:08 lucainnocenti

It shouldn't be a problem, but it is :)

The way that the high-dpi displays are handled is by adding a layer of 'virtual pixels' that unless you opt-out just 'zooms' your bitmaps by 2x. What looks like is happening here is that the js side is correctly opting out, but it is not being threaded through to matplotlib to render the image and double the 'virtual' dpi until after the cell is finished executing.

Until we sort this out splitting everything after plt.show() into a second cell may help.

tacaswell avatar Aug 26 '17 14:08 tacaswell

thanks for the comment @tacaswell. What do you mean exactly by "splitting evething (...) into a second cell"?

lucainnocenti avatar Aug 27 '17 16:08 lucainnocenti

I mean put it in a second cell so the first cell creates and show the figure, the second updates it.

tacaswell avatar Sep 22 '17 19:09 tacaswell

I am also running into this issue -- exactly the same plotting mechanism and symptoms (on the latest Anaconda). It would be nice if it wasn't necessary to split the plots in this way when using Retina displays (which is basically all macs nowadays).

wjakob avatar Aug 19 '18 21:08 wjakob

@wjakob The parameter that controls this is https://github.com/matplotlib/jupyter-matplotlib/blob/master/ipympl/backend_nbagg.py#L141 .

I suspect what is happening is:

  • you call show which creates the figure
  • the js side sends a message back to adjust the DPI
  • but the event loop is blocked running your code which loops through and and updates the plot
  • after you loop is done the tornado event loop processes the message to update the DPI ratio which triggers a re-draw which shows you the full size figure.

One (very hackish) solution is to do fig.canvas._dpi_ratio = 2 and just hard-code you are in a hi-dpi enviroment. The more proper solution is to find a way to let the underlying event loop spin, but I do not know how to do that...

tacaswell avatar Aug 22 '18 22:08 tacaswell

any solution to this problem? fig.canvas._dpi_ratio = 2 doesn't change anything to me

tiehfood avatar Jan 17 '19 14:01 tiehfood

@tiehfood I think someone needs to look into the communications between the js front end and the python side to sort out when the dpi is negotiated, would you be interested in trying?

The revelant code is likely in https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/backends/backend_webagg_core.py and https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/backends/backend_nbagg.py

tacaswell avatar Jan 17 '19 14:01 tacaswell

I am no code expert and I have just access to the jupyter front end in this case...

tiehfood avatar Jan 17 '19 15:01 tiehfood

I tried to find the reason for this issue. I added print statements to the messages handling Python side, and it appears that all the messages (i.e. initialized message, set_dpi_ratio message, resize message) are received/handled only at the end of the animation... I don't know what is the reason for that. Maybe you have an idea @tacaswell ?

martinRenou avatar Jul 02 '19 09:07 martinRenou

As we are not using the tornado application with ipympl, I suspect the way to fix it would be to get rid of it on the backend

martinRenou avatar Jul 02 '19 10:07 martinRenou

Any updates on this front?

malbergo avatar Dec 03 '20 22:12 malbergo

This bug is now 3 years old and I still have this issue. Are there any plans how this can be fixed?

KIC avatar Jan 04 '21 11:01 KIC

Hi Guys,

I was facing the same issue, I was creating different plots into the same cell using a loop, the way I fixed it was putting the fig = plt.figure(figsize=(20, 10)) inside the loop. Now all the plots has the same size into the execution of the same cell. I had it out of the loop before.

Check the example below:

image

Wittline avatar Sep 10 '21 04:09 Wittline