tag-manager
tag-manager copied to clipboard
matomo-org
[Bug] "All Websites" still shown in website selector in the MTM screen
What happened?
In https://github.com/matomo-org/matomo/issues/20492 we removed "All websites" from the website selector. While this is correctly applied to the website selector on the dashboard, it seems not to have been applied to the every website selector everywhere on the platform. For example, I just found it in the website selector in the Matomo Tag Manager screen. Note: I haven't found other places where the change was not applied.
What should happen?
- Remove "All websites" from the selector in the Tag Manager screen
- Check if there are any other website selectors where this change wasn't applied
How can this be reproduced?
- Go to Tag Manager (top right in dashboard screen)
- Click on the website selector
- All websites is at the bottom of the dropdown
Matomo version
Cloud (RC9)
PHP version
No response
Server operating system
No response
What browsers are you seeing the problem on?
No response
Computer operating system
No response
Relevant log output
No response
Validations
- [X] Read our Contributing Guidelines.
- [X] Follow our Security Policy.
- [X] Check that there isn't already an issue that reports the same bug to avoid creating duplicates.
- [X] The provided steps to reproduce is a minimal reproducible of the Bug.
This needs to be changed in tag manager itself.
@sgiehl I did a search for CoreHome.SiteSelector and it looks like we have several plugins that use that component without setting the show-all-sites-item attribute to false. The plugins team will take care of those. I also noticed that plugins/CustomDimensions/templates/manage.twig uses it without setting that attribute as well. Is that intentional or will a core change be needed for that?
Makes sense to hide it for custom dimensions as well. I'll create a PR for that.