tag-manager icon indicating copy to clipboard operation
tag-manager copied to clipboard

Add a new field custom URL Referrer on pageview tag

Open tomper00 opened this issue 3 years ago • 3 comments

Description:

This is often needed when you work with SPA tracking since the Referrer often is not updated on virtual pageviews. It is also nice to be able to create a custom JS Variable some times to be able to filter out PII etc.

Review

tomper00 avatar Nov 04 '22 17:11 tomper00

Ok thanks again for the feedback @snake14 I will go with the option to merge my branches, that sounds like an easy way forward.

tomper00 avatar Nov 07 '22 11:11 tomper00

Ok thanks again for the feedback @snake14 I will go with the option to merge my branches, that sounds like an easy way forward.

@tomper00 I just left a comment on your other PR, but I realised that I had you use the wrong class for the migration. Since this one is for a tag, you would use the NewTagParameterMigrator class. You can still merge your branches, but you'd need two lines instead of just the one:

$migrator = new NewTagParameterMigrator(MatomoTag::ID, 'customUrlRef');
$migrator->migrate();

So, if you merge the two branches, you would run NewTagParameterMigrator->migrate() for your tag column and NewVariableParameterMigrator->migrate() for your two variable columns.

snake14 avatar Nov 07 '22 21:11 snake14

@tomper00 Any update on this ?

AltamashShaikh avatar Jun 04 '24 04:06 AltamashShaikh