tag-manager
tag-manager copied to clipboard
Add a new field custom URL Referrer on pageview tag
Description:
This is often needed when you work with SPA tracking since the Referrer often is not updated on virtual pageviews. It is also nice to be able to create a custom JS Variable some times to be able to filter out PII etc.
Review
- [ ] Functional review done
- [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- [ ] Security review done
- [ ] Wording review done
- [ ] Code review done
- [ ] Tests were added if useful/possible
- [ ] Reviewed for breaking changes
- [ ] Developer changelog updated if needed
- [ ] Documentation added if needed
- [ ] Existing documentation updated if needed
Ok thanks again for the feedback @snake14 I will go with the option to merge my branches, that sounds like an easy way forward.
Ok thanks again for the feedback @snake14 I will go with the option to merge my branches, that sounds like an easy way forward.
@tomper00 I just left a comment on your other PR, but I realised that I had you use the wrong class for the migration. Since this one is for a tag, you would use the NewTagParameterMigrator class. You can still merge your branches, but you'd need two lines instead of just the one:
$migrator = new NewTagParameterMigrator(MatomoTag::ID, 'customUrlRef');
$migrator->migrate();
So, if you merge the two branches, you would run NewTagParameterMigrator->migrate() for your tag column and NewVariableParameterMigrator->migrate() for your two variable columns.
@tomper00 Any update on this ?