tag-manager icon indicating copy to clipboard operation
tag-manager copied to clipboard

Rename Custom JS Variable error + doesn't propagate new name in the other container objects

Open lneuville opened this issue 2 years ago • 10 comments

Hi guys,

I've experienced a rather painful issue that I've reproduced, so I beleive it's the right place to share it... It may be a bug, or at minima a wording issue in displayed messages ;

Here are the steps :

  • context : Matomo Cloud

1 - I have a Custom JS variable that I use in all my Triggers.

trigger-initial-state-with-variable-name1

2 - In order to give it a more meaningful name, I simply renamed it. Adding 'TEST' in the name, and then submit the change.

variable-rename-adding-test-in-name

3 - Here I got an error message... regarding an Event Name that must be provided... I didn't understand why :

variable-rename-error

4 - Then I re-submit the change... this time I have a 'OK-success' message :

variable-rename-re-submit-ok

5 - But when I check my Trigger with the Variable name, it didn't update (the 'TEST' bit is missing).

trigger-with-variable-name-not-changed-to-new-name

Thanks for taking a look.

Best regards

Laurent

lneuville avatar Oct 07 '22 09:10 lneuville

Hi @lneuville . Thank you for taking the time to create this issue. Which version of Matomo are you currently using? Matomo version 4.12 was recently released and this sounds very similar to an issue that I fixed as part of that release. If possible, please upgrade to Matomo version 4.12 and let me know if the issue persists. I'm going to mark this issue as closed, but please feel free to let me know if you think it should be re-opened.

snake14 avatar Oct 09 '22 20:10 snake14

Hi @snake14 . Thanks for you're feedback. Sorry I wasn't mentioned clearly enough on my post ; It was on Matomo Cloud. So I don't really know which version number is currently running on the cloud service.

lneuville avatar Oct 10 '22 07:10 lneuville

@lneuville You can check this FAQ to find out which version you are on cloud.

AltamashShaikh avatar Oct 10 '22 07:10 AltamashShaikh

Ok, It says 4.12. So I as I reproduced it with the steps described in my first post, I would say the issue is still here.

lneuville avatar Oct 10 '22 09:10 lneuville

@lneuville How long ago did you validate your issue? I only ask because version 4.12 was released mid-week last week and I think it usually takes a few days for cloud to be upgraded. It's possible you tested the issue just before cloud was upgraded. Could you please quickly verify one more time that the issue still exists?

snake14 avatar Oct 10 '22 20:10 snake14

@lneuville I didn't hear back. Does that mean that things are working correctly now? I tried to reproduce the issue in my local environment, but the variable was correctly renamed in the referencing trigger when I renamed the variable. I'm going to go ahead and close this issue again. Please let me know if you're still experiencing the issue.

snake14 avatar Oct 12 '22 21:10 snake14

Hi @snake14 Just tried again. And reproduced. I also tried another type of Variable (Datalayer variable) and experienced the same issue.

lneuville avatar Oct 13 '22 08:10 lneuville

@lneuville That is so strange. I apologise for this continued issue. Are there any errors logged around the time that you try to update the variable name?

Just to be absolutely sure, could you please check what version of Matomo is listed in your instance? You can do that, while logged into Matomo, by going to Administration (Gear icon) > Diagnostic > System Check ({your matomo base url}/index.php?module=Installation&action=systemCheckPage) and scrolling down to the Information results section, which should look something like this: image

snake14 avatar Oct 13 '22 20:10 snake14

Hi @snake14 As I was saying before. I'm on the Cloud Version - 4.12 And I don't see a "System Check" option in the Diagnostic section... image

lneuville avatar Oct 14 '22 10:10 lneuville

@lneuville Sorry about that. I'm not very familiar with the cloud configuration yet. Are you seeing any errors in your log when you try to rename a variable and the issue occurs? Since I can't reproduce the issue, I need more information. Any recommendations @AltamashShaikh ?

snake14 avatar Oct 16 '22 20:10 snake14