Google Ads Tag

[Findus23]

followup to #12 (many thanks to @pebosi)

TODO:

• [ ] add AdwordsConversionTagHelp
• [ ] check if google_conversion_format needs to be a string
• [ ] add docs to all parameters and check if they and the validators are correct.
• [ ] test if it works

[Findus23]

@peterbo, @duracelltomi I know nothing about Adwords, but I implemented the tag explained in https://tosbourn.com/tracking-adwords-conversion-javascript/

Can you please take a look if it works and if something is broken or missing?

Many thanks!

[duracelltomi]

This is great for az initial version but with that, users can not implement dynamic remarketing yet. To be able to do so, this tag template will need a list of user entered key-value pairs. The output should be a JSON object as shown on this page:

https://developers.google.com/adwords-remarketing-tag/implementation

var google_tag_params = { parameter1: 'abc123', parameter2: 29.99 };

[peterbo]

LGTM - I'm not very familiar with the remarketing feature of the pixel, but it seems quite straight forward. But for the initial version, it looks good!

[Findus23]

@duracelltomi Thanks for the feedback.

Thankfully Matomo has a new UI element that's perfect for entering key-value pairs:

results in

[{"index":"key1","value":"val"},{"index":"morekey","value":"othervalue"},{"index":"","value":""}]

But I am not sure what exactly you mean with google_tag_params. Do you mean that I should add google_tag_params to the dictionary passed to google_trackConversion?

I'm a bit confused because it doesn't start with google_conversion as the others

[duracelltomi]

Does this key-value element also allow to add variables in the "Value" column?

For dynamic remarketing to work, people will need to add dynamic values into the data layer and this will need a variable on the UI and this variable will need to be attached the a value in this table.

The generated output is however not OK, you should add a transformation from this:

[
  {
    "index":"key1",
    "value":"val"
  },
  {
    "index":"morekey",
    "value":"othervalue"
  },
  {
    "index":"","value":""
  }
]

... into this:

{
  "key1": "val",
  "morekey": "othervalue"
}

(ignoring empty lines as well)

[Findus23]

Does this key-value element also allow to add variables in the "Value" column?

It does now.

you should add a transformation from this:

Thanks for the reminder, I ran out of time yesterday to do it properly.

Is the way I am defining google_tag_params now correct?

[duracelltomi]

I am not sure whether google_conversion_label should include the conversion ID as well:

configObject.google_conversion_label = conversionID + '/' + parameters.get('conversionLabel');

google_tag_params should be a global variable within window

[Findus23]

configObject.google_conversion_label = conversionID + '/' + parameters.get('conversionLabel');

Isn't that what I am doing in https://github.com/matomo-org/tag-manager/pull/50/files#diff-460e870295a18cef54721b951bbf0bbeR42?

google_tag_params should be a global variable within window

Fixed in https://github.com/matomo-org/tag-manager/pull/50/commits/f1ee502db6e44b6dea0411bcae850abe91b2fcba

[mattab]

Just created https://github.com/matomo-org/tag-manager/issues/159 (didn't notice this PR.) @Findus23 be great if you could finish the PR and get this merged as a few users have requested the feature :ok_hand:

[tsteur]

@mattab what we would need is someone to test it which we can't really do ourselves.

[mattab]

Feedback:

• Google Adwords was renamed to Google Ads. Could we change the wording and maybe icons to reflect new branding? https://designguidelines.withgoogle.com/ads-branding/google-ads/logos.html#logos-brand-logo-lockups
• Maybe we could mark this tag as "Beta" and release it so we can ask people to test?
  • Or what is needed to test this feature, we do have a test account if you'd like @Findus23

[tsteur]

@Findus23 are you still working on this?

[Findus23]

@tsteur No, as I have no way to test it. But I can put updating Logo/Name on my todo list.

[mattab]

@Findus23 Be great if you can update name/logo and then we'll work on finding someone to help this new feature. It keeps getting asked from time to time. Thanks!

[Findus23]

@mattab Done :heavy_check_mark:

[mattab]

@duracelltomi @peterbo would you be able to test this new Google Ads Tag in Matomo Tag Manager? To test you can apply this patch to your Tag Manager: https://patch-diff.githubusercontent.com/raw/matomo-org/tag-manager/pull/50.patch

Or create the 3 new files, and replace plugins/TagManager/lang/en.json by this file: https://raw.githubusercontent.com/matomo-org/tag-manager/8ee55f85b4678f8dd205d92ebca34452bdb24e60/lang/en.json

Be awesome if you can test and confirm if this new tag works for you?

[duracelltomi]

I have a super busy week, I can not test this before next week

[mattab]

Hi @duracelltomi - Do you think you'd be able to test this PR in the next few days? That would be very helpful to us!

[maba4891]

I was wondering: What happened to this feature? Would be super helpful I believe (also see https://forum.matomo.org/t/google-ads-tag-in-matomo-tag-manager/40284/2)

[Findus23]

@maba4891 Noone who knows Google Ads well did yet have time to test it extensively, so it could not yet be merged.

[Chardonneaur]

Hey, any news dealing with this support ticket, I have a client of mine who would be super interested in having it.

[Chardonneaur]

Hi guys, any news dealing with the integration of this template? there is a high demand about it.

[snake14]

That's a good question @Chardonneaur . Do we know what happened with this feature @mattab ? This PR looks pretty old and it's set to merge into master instead of the development branch. Should we try to salvage it?

[Chardonneaur]

there is a bing ads tracker template, normally, a Google Ads tracker shouldn't be complicated to publish, there are two additional fields I guess.

[ronan-hello]

Hi, Google Ads tag is ready in this community plugin https://plugins.matomo.org/TagManagerExtended#preview You can copy this template and integrate it into the TagManager?

[AltamashShaikh]

@Stan-vw This would definitely be a good addition, @ronan-hello is there anyway you can send a PR to include this tag ? We would be happy to merge a PR for this feature