plugin-GoogleAnalyticsImporter icon indicating copy to clipboard operation
plugin-GoogleAnalyticsImporter copied to clipboard

Published 20 hours ago • verified publisher icon matomo-org

AuthorizationGA4.php does not respect Matomo proxy setting.

Open machinehum opened this issue 1 year ago • 2 comments

Code to support the Matomo proxy setting was recently added via PR #202. This change applies to GoogleAnalyticsImporter.googleClient, which is used by Authorization.php::getConfiguredClient() for GA3. However, GA4 does not use GoogleAnalyticsImporter.googleClient, and a GA4 import from behind a proxy will timeout at the initial OAuth exchange with oauth2.googleapis.com, because the remote host is unreachable.

This probably belongs in GoogleAnalyticsGA4Importer.clientConfiguration but I'm not entirely sure. Tagging @snake14 since you moved #202 forward.

machinehum avatar Apr 26 '24 20:04 machinehum

Hi @machinehum . Good catch. Sorry that I missed that in the PR. I'll see if I can create a new PR later today that addresses the GA4 issue.

snake14 avatar Apr 28 '24 20:04 snake14

Thanks! Looking forward to it.

machinehum avatar Apr 29 '24 15:04 machinehum