matomo Updates Symfony components to 5.4.x

Updates Symfony components to 5.4.x

Open sgiehl opened this issue 2 years ago • 6 comments

Description:

We are currently still using Symfony Console (and other components) in version 2.6. This one is quite outdated and has some issues with PHP 8.1 (deprecation warnings).

This PR will update all components to the last available version 5.4.x.

So far there were two issues I have identified after the update:

The monolog class ConsoleFormatter does not longer have multiple constructor parameters, but takes an option array instead. This was adjusted in plugins/Monolog/config/cli.php
The execute method of a console command is now kind of forced to return an integer. Before that was kind of expected, but all other values were silently treated as 0. I have adjusted our command class, so it will catch and log that error and return 0 in that case. That way commands that may not yet be adjusted won't fail. I have nevertheless changed all commands in core here and already created PRs for the submodule plugins.
The DialogHelper has been deprecated and removed meanwhile. I've added it back for BC, but we need to migrate our usage to the QuestionsHelper instead.

Review

[ ] Functional review done
[ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
[ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
[ ] Security review done
[ ] Wording review done
[ ] Code review done
[ ] Tests were added if useful/possible
[ ] Reviewed for breaking changes
[ ] Developer changelog updated if needed
[ ] Documentation added if needed
[ ] Existing documentation updated if needed

Nov 16 '21 14:11 sgiehl

Thanks for the comments @mickaelandrieu. This PR and the symfony updates are now scheduled for the 5.0.0 milestone as our initial look suggests it will require BC breaks.

Dec 03 '21 00:12 justinvelluppillai

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

Dec 19 '21 01:12 github-actions[bot]

Updated the PR so it will require Symfony 5.4 instead. Once I've fixed all tests, this one should be ready to review.

Aug 23 '22 15:08 sgiehl