matomo-php-tracker icon indicating copy to clipboard operation
matomo-php-tracker copied to clipboard

Published 20 hours ago • verified publisher icon matomo-org

129 - Creation of dynamic property MatomoTracker::$currentTs is deprecated

Open lutdev opened this issue 1 year ago • 3 comments

Description:

I created properties to fix the problem with the dynamic properties. All default values I took from the __construct() Issue: https://github.com/matomo-org/matomo-php-tracker/issues/129

I would be happy to update CHANGELOG but have no idea how my updates should look like.

lutdev avatar Apr 17 '24 23:04 lutdev

Thanks for starting the PR @lutdev. Is there a reason to have the properties public? Are they used outside of the class? I'd imagine they can be private, protected at most. What do you think?

michalkleiner avatar Apr 17 '24 23:04 michalkleiner

@michalkleiner you are welcome :) The main reason to make not breaking changes. If the properties will be public, developers still can use them as they use them now. Later we can try to make them private/protected step by step.

lutdev avatar Apr 18 '24 20:04 lutdev

@michalkleiner just a friendly reminder about PR :)

lutdev avatar May 01 '24 12:05 lutdev