device-detector
device-detector copied to clipboard
matomo-org
feat(stream-softwares) add support of stream softwares browser
Description:
Fix #7391
It allow to detect browser included in streaming softwares .
Review
- [ ] Functional review done
- [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- [ ] Security review done
- [ ] Wording review done
- [ ] Code review done
- [ ] Tests were added if useful/possible
- [ ] Reviewed for breaking changes
- [ ] Developer changelog updated if needed
- [ ] Documentation added if needed
- [ ] Existing documentation updated if needed
@sanchezzzhak In fact, I'm not sure to understand why ?
I tried to write it like a mobile app, but so I loose the engine informations (information which is maybe more important than the software version)
Else, I can create a new ClientParser just for this kind of client . Mainly extending Browser Parser, and just changing the type / fixtures ... But not sure if it's a good idea or not
We did not plan to introduce the type of engine for apps, this issue was also raised earlier, then and now it is pointless. #6177, #5923
Browsers must have an engine. These applications for PR are not browsers, although they are written in electron with HTML code output to the screen.
Applications such as the Curse client (twitch client), MangoBooster, Battle.Net launcher, Wargaming launcher, Epic Games, Steam, Origin, UplayLauncher
They also display their content through the browser, but we don't consider them as browsers.
@sanchezzzhak you should close this one too, as it has been fixed in https://github.com/matomo-org/device-detector/pull/7587
