device-detector icon indicating copy to clipboard operation
device-detector copied to clipboard

Oneplus 3T and Oneplus 3 have the same build number

Open Findus23 opened this issue 8 years ago • 1 comments

I just noticed that my Oneplus 3T is detected as an Oneplus 3 The user agent is Mozilla/5.0 (Linux; Android 7.1.2; ONEPLUS A3003 Build/NJH47F) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/60.0.3112.78 Mobile Safari/537.36

Unfortunatly I can't think of an solution as according to wikipedia the build numbers A3000 and A3003 belong to both 3 and 3T. (I just checked the battery size to make sure I really own a 3T 😄)

https://github.com/piwik/device-detector/blob/121bf5ef733aa8abaca79e0bd49a55710ebd5694/regexes/device/mobiles.yml#L3876-L3879

What do you do in other cases where multiple devices have the same build number?

Findus23 avatar Nov 13 '17 18:11 Findus23

Guess in such cases we can only try to group in a useful way, such as XY series or in this case maybe we should simply detect all as 3 / 3T

sgiehl avatar Nov 13 '17 18:11 sgiehl