device-detector icon indicating copy to clipboard operation
device-detector copied to clipboard

Porting to Java

Open mmarmol opened this issue 9 years ago • 4 comments

I am thinking on porting this to Java, I have looked around the code and it can be done. Just have a doubt if you guys are planning to separate the regex data and list of types/devices from the actual code doing the parsing. Also any advice to look for before starting is welcome.

Cheers,

mmarmol avatar Jul 01 '16 03:07 mmarmol

Sorry for the long delay. What do you mean with separating the data? Moving it to an own repository?

sgiehl avatar Jul 16 '16 07:07 sgiehl

Hi, yes ideally take it to another project and set up the regex from the yaml, and all the necessary to put together the same test cases in different languages. Check what the guys from https://github.com/ua-parser/uap-core are doing for this. We are current working with their lib but preatty much looking to migrate to device-detector from some capabilities that are only present which makes lot of sense to us. Also check this https://github.com/piwik/device-detector/blob/master/Parser/Client/Browser.php, you will find that the browser list is added on the code, which is fine but do things like auto-update kinda impossible for most languages. Ideally have this kind of information out of the code also would be excellent. Hope this makes any sense.

mmarmol avatar Jul 17 '16 00:07 mmarmol

Hi @mmarmol - that's a good idea. We welcome pull requests to improve the Device Detector :+1:

mattab avatar Aug 03 '16 06:08 mattab

It's a old issue but are you planning to separate the regex data and lists from the code ? Could be great for ports in other languages.

pierrocknroll avatar Jun 11 '18 13:06 pierrocknroll