Matthias Mair

Results 591 comments of Matthias Mair

This is expected behaviour IMO. All (django) apps must be reloaded for model discovery once AppMixin plugins are activated thus running all ready() methods twice (once during "normal" startup and...

From what I rember we had multiple unexplainable problems with plugin models before the PR and I am not aware of any after. There were these random plugin errors in...

Sample: https://github.com/matmair/InvenTree/actions/runs/9860962099/attempts/1#summary-27228345488

@SchrodingersGat @wolflu05 should the diff also be added as a comment?

As a PR comment. Not sure if it would be too noisy

@wolflu05 it helps to see the real effect on the schema without making the diff yourself. This example shows that only the info field changed so a new API revision...

@wolflu05 I have merged this with #7667 for a sample - here is the output https://github.com/matmair/InvenTree/actions/runs/9964062291/attempts/1#summary-27531527133

The small code change effects the response on 21 Endpoints, most of the them both on POST and GET. So not really a small change if you look at the...

@SchrodingersGat yes, ready to merge

Very exciting! Is the removal of json/yaml a permanent change or something that was not in scope for the initial implementation?