Option to swap left/right in diff

[ltrzesniewski]

I tend to think as the left/right panes of a diff window as before/after. Having the received file on the left feels unnatural to me. I'd prefer it to show verified/received rather than received/verified.

DiffEngine already has that option.

Unfortunately, this requires adding a settings screen for the plugin, which, I suppose, is nontrivial.

[SimonCropp]

@ltrzesniewski is there some reason u dont want to use the environment variable?

[ltrzesniewski]

That's because I set DiffEngine_Disabled to true, so DiffEngine_TargetOnLeft doesn't work.

I think I got used to this though, so feel free to close.

[matkoch]

First, about the issue itself: adding an options page is not a problem at all. The reason I didn't do this already is because of coloring for additions/deletions in Rider's diff viewer. The two options are:

Received/Verified

Verified/Received

In the latest version, I already swapped the two sides for (my subjective) better coloring. But I realize that is not how everyone is looking at it.

So what we can do is:

• Pick one for all
• Allow for configuration, but with possibly confusing coloring

[matkoch]

One more note: I guess it's not possible to set DiffEngine_TargetOnLeft in the same way as DiffEngine_Disabled. That is because those environment variables are set for the test runner process. But we need the configuration value after test evaluation and at action invocation.

[ltrzesniewski]

Well, I'd say since you got #17 and #29 which contradict each other, a configuration page would probably be best 🙂

[siewers]

I would love to see the Verified on the left and the Received on the right. I've been using this plugin for a while and still haven't gotten used to it. Since I read from left to right, when I see the diff, I look at it in the sense of what it was (on the left) and what it has become (on the right). I don't know if that makes sense :)

I just realized that in GitKraken, the diff tool also shows the previous version on the left and the new version on the right. Maybe that is contributing to the reason why this is throwing me off.