common icon indicating copy to clipboard operation
common copied to clipboard

Published 20 hours ago • verified publisher icon matkoch

Feature/wix

Open jonsth131 opened this issue 6 years ago • 4 comments

Adds WiX-support for the following tools:

  • Candle
  • Heat
  • Insignia
  • Smoke
  • Nit
  • Lux
  • Lit
  • Cop
  • Light
  • Torch
  • Pyro

jonsth131 avatar Mar 18 '19 16:03 jonsth131

I think this is not the way I want to go regarding the toolpath implementation. ReSharper.CommandLineTools with its cleanupcode.exe, dupfinder.exe and inspectcode.exe is similar. I have no solution yet, and thus no ETA.

matkoch avatar Mar 22 '19 20:03 matkoch

I didn’t mean to close it, but I can’t merge it just yet, because there needs to be a decision how to handle such cases.

matkoch avatar Mar 22 '19 23:03 matkoch

Not sure what the issue was here, but isn't WiX available as a NuGet package? (or perhaps this wasn't the problem at all, if so, please disregard) (https://www.nuget.org/packages/WiX)

alphaleonis avatar May 15 '19 19:05 alphaleonis

Please disregard the statement above. I mistook some unofficial packages for official ones (I think).

But I would really like to see this implemented in the tooling as well. For Wix 3.x I don't see how we could determine the toolpath other than either using the WIX environment variable as was done here which is set when installing WiX, or requiring it to be in the path. Perhaps allowing it to be overridden per build script if needed?

If this isn't acceptable for inclusion in Nuke.Common, perhaps you could release this as a separate package @jonsth131, i.e. Nuke.WiX or something like that?

alphaleonis avatar Oct 25 '19 08:10 alphaleonis