KDE-Rounded-Corners icon indicating copy to clipboard operation
KDE-Rounded-Corners copied to clipboard

Second outline?

Open Akselmo opened this issue 1 year ago • 6 comments

Hi, this effect is pretty cool and I like using it.

However, I would like to have two outlines:

  1. The inner one is the current one
  2. Outer 1px width outline that is just plain black

This screenshot is from Aurorae theme I made from Arc Dark Aurorae, but basically this is the effect I am after

image

I actually wouldn't mind implementing this! However, I have no idea where to even begin. I don't really understand where the outline is drawn in the shader code, and I don't have much experience on shaders in the first place.

So if anyone could point me in right direction, I could implement it and make a setting for it, then contribute upstream, if this is a feature you're interested in having :) Even if not, I wouldn't mind making the effect for myself.

Thanks!

Akselmo avatar Sep 21 '23 19:09 Akselmo

I like this very much! You are absolutely right that the code is documented very poorly. So before we begin on this, as I already mentioned in another pull request #101, I should add documentation on the current implementation and enable others to contribute more effectively.

matinlotfali avatar Sep 23 '23 09:09 matinlotfali

Sounds good to me, I have time to work on this whenever.

Akselmo avatar Sep 23 '23 09:09 Akselmo

@Akselmo I added a lot of comments for you in #121

matinlotfali avatar Dec 17 '23 07:12 matinlotfali

Thanks, will give it a looksie!

Akselmo avatar Dec 17 '23 10:12 Akselmo

@Akselmo any progress on second outline?

SATYADAHAL avatar Jan 23 '24 05:01 SATYADAHAL

Sorry ive been so busy i forgot. I could try this on weekend possibly but cant promise anything. If someone else wants to make this, go right ahead :)

Akselmo avatar Jan 23 '24 08:01 Akselmo

@Akselmo @SATYADAHAL Let's test #230

matinlotfali avatar May 23 '24 18:05 matinlotfali

Works like a charm @matinlotfali Thanks for maintaining this project. KDE rounded corner must be there by default in desktop effects.

SATYADAHAL avatar May 30 '24 12:05 SATYADAHAL