bor icon indicating copy to clipboard operation
bor copied to clipboard

Dump IO Usage

Open pratikspatil024 opened this issue 3 years ago • 1 comments

Jira Task: POS-573

pratikspatil024 avatar Jul 27 '22 06:07 pratikspatil024

Codecov Report

Merging #473 (8ee6f6c) into block-stm (ecedc65) will increase coverage by 0.04%. The diff coverage is 65.11%.

@@              Coverage Diff              @@
##           block-stm     #473      +/-   ##
=============================================
+ Coverage      56.11%   56.15%   +0.04%     
=============================================
  Files            604      607       +3     
  Lines          70109    70171      +62     
=============================================
+ Hits           39341    39406      +65     
+ Misses         27368    27364       -4     
- Partials        3400     3401       +1     
Impacted Files Coverage Δ
core/parallel_state_processor.go 0.00% <0.00%> (ø)
core/state/statedb.go 62.41% <0.00%> (-0.89%) :arrow_down:
eth/tracers/api.go 26.89% <84.37%> (+4.09%) :arrow_up:
core/state_transition.go 88.16% <100.00%> (ø)
rpc/server.go 72.50% <0.00%> (-5.00%) :arrow_down:
p2p/enode/nodedb.go 70.46% <0.00%> (-3.11%) :arrow_down:
les/vflux/client/serverpool.go 76.76% <0.00%> (-1.66%) :arrow_down:
p2p/discover/v4_udp.go 75.65% <0.00%> (-1.45%) :arrow_down:
eth/protocols/snap/sync.go 70.45% <0.00%> (-1.28%) :arrow_down:
les/odr.go 89.02% <0.00%> (-1.22%) :arrow_down:
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ecedc65...8ee6f6c. Read the comment docs.

codecov-commenter avatar Jul 27 '22 07:07 codecov-commenter

Looks like linter failed. Could you fix before merging?

cffls avatar Aug 18 '22 05:08 cffls

@cffls @JekaMas I am not getting the lint errors on my local machine. Also, these lines, where the CI is throwing an error is not present in the code.

Error: core/parallel_state_processor.go:137:1: cognitive complexity 32 of func `(*ParallelStateProcessor).Process` is high (> 30) (gocognit)
func (p *ParallelStateProcessor) Process(block *types.Block, statedb *state.StateDB, cfg vm.Config) (types.Receipts, []*types.Log, uint64, error) {
^
Error: core/parallel_state_processor.go:101:3: if statements should only be cuddled with assignments (wsl)
		if _, ok := task.statedb.MVReadMap()[string(task.result.BurntContractAddress.Bytes())]; ok {
		^
Error: core/parallel_state_processor.go:195:4: branch statements should not be cuddled if block has more than two lines (wsl)
			break

pratikspatil024 avatar Aug 18 '22 07:08 pratikspatil024

@cffls @JekaMas I am not getting the lint errors on my local machine. Also, these lines, where the CI is throwing an error is not present in the code.

Error: core/parallel_state_processor.go:137:1: cognitive complexity 32 of func `(*ParallelStateProcessor).Process` is high (> 30) (gocognit)
func (p *ParallelStateProcessor) Process(block *types.Block, statedb *state.StateDB, cfg vm.Config) (types.Receipts, []*types.Log, uint64, error) {
^
Error: core/parallel_state_processor.go:101:3: if statements should only be cuddled with assignments (wsl)
		if _, ok := task.statedb.MVReadMap()[string(task.result.BurntContractAddress.Bytes())]; ok {
		^
Error: core/parallel_state_processor.go:195:4: branch statements should not be cuddled if block has more than two lines (wsl)
			break

Actually these changes were added in this commit in the base repo (block-atm). And I think because of that the linters are failing. These will be resolved, but one lint error which might need some thinking is. this one:

Error: core/parallel_state_processor.go:142:1: cognitive complexity 32 of func `(*ParallelStateProcessor).Process` is high (> 30) (gocognit)

pratikspatil024 avatar Aug 18 '22 10:08 pratikspatil024

I guess it is okay to merge then, since some failed linters are caused by another commit. We can fix linter issues altogether in this PR: https://github.com/maticnetwork/bor/pull/490

cffls avatar Aug 18 '22 17:08 cffls