bor icon indicating copy to clipboard operation
bor copied to clipboard

consensus/bor/heimdall: add new meter and timer metrics in heimdall client

Open manav2401 opened this issue 2 years ago • 1 comments

This PR adds new timer and meter metrics for the heimdall client for gathering relevant data. For now, it keeps track of duration of each request to heimdall and the success and failure count.

TODOs

  • [ ] Add additional metrics
  • [ ] Check and verify on datadog

manav2401 avatar Jul 19 '22 13:07 manav2401

Codecov Report

Merging #459 (8e13b0f) into develop (2a92cb1) will decrease coverage by 0.05%. The diff coverage is 32.00%.

@@             Coverage Diff             @@
##           develop     #459      +/-   ##
===========================================
- Coverage    56.96%   56.90%   -0.06%     
===========================================
  Files          609      610       +1     
  Lines        69978    70000      +22     
===========================================
- Hits         39864    39836      -28     
- Misses       26718    26766      +48     
- Partials      3396     3398       +2     
Impacted Files Coverage Δ
consensus/bor/heimdall/metrics.go 9.09% <9.09%> (ø)
consensus/bor/heimdall/client.go 49.20% <50.00%> (-0.36%) :arrow_down:
p2p/discover/v4_udp.go 72.75% <0.00%> (-5.51%) :arrow_down:
p2p/simulations/mocker.go 30.00% <0.00%> (-4.45%) :arrow_down:
console/console.go 62.69% <0.00%> (-3.97%) :arrow_down:
p2p/discover/table.go 82.48% <0.00%> (-3.65%) :arrow_down:
rlp/typecache.go 89.53% <0.00%> (-2.33%) :arrow_down:
consensus/ethash/ethash.go 55.34% <0.00%> (-1.15%) :arrow_down:
p2p/simulations/network.go 57.76% <0.00%> (-0.88%) :arrow_down:
trie/trie.go 76.47% <0.00%> (-0.74%) :arrow_down:
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Jul 22 '22 05:07 codecov-commenter

DD updates confirmed - clear to go.

Leon-Africa avatar Aug 19 '22 10:08 Leon-Africa

DD updates confirmed - clear to go.

Confirmed on DD. All looks good. Link to the list of metrics for reference. We can proceed with merge. @JekaMas @temaniarpit27

manav2401 avatar Aug 20 '22 10:08 manav2401

Looks good to me!

JekaMas avatar Aug 20 '22 11:08 JekaMas