bor icon indicating copy to clipboard operation
bor copied to clipboard

chore: drop legacy // +build comment

Open findfluctuate opened this issue 1 month ago • 1 comments

Description

From Go 1.17, the preferred syntax for build constraints is //go:build, which replaces the old // +build form. The old style is now considered deprecated but still supported for backward compatibility.

This change removes the obsolete // +build xxx line, keeping only the modern //go:build xxx directive.

More info: https://github.com/golang/go/issues/41184 and https://go.dev/doc/go1.17#build-lines

Design Doc / Proposal: https://go.dev/design/draft-gobuild

Changes

  • [ ] Bugfix (non-breaking change that solves an issue)
  • [ ] Hotfix (change that solves an urgent issue, and requires immediate attention)
  • [x] New feature (non-breaking change that adds functionality)
  • [ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • [ ] Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • [ ] I have added at least 2 reviewer or the whole pos-v1 team
  • [ ] I have added sufficient documentation in code
  • [ ] I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • [ ] Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • [ ] Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • [ ] This PR requires changes to heimdall
    • In case link the PR here:
  • [ ] This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • [ ] I have added unit tests
  • [ ] I have added tests to CI
  • [ ] I have tested this code manually on local environment
  • [ ] I have tested this code manually on remote devnet using express-cli
  • [ ] I have tested this code manually on amoy
  • [ ] I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

findfluctuate avatar Dec 12 '25 08:12 findfluctuate

@kamuikatsurgi @pratikspatil024

Hi, Could you please review this PR at your convenience? Thank you very much.

It seems that the CI failure is unrelated to this change

  Progress: 3445/6000 transactions mined (120 seconds elapsed)
Load test still running after timeout, terminating...
Waiting 10 seconds for final transactions to settle...

=== Final Verification ===
Test results:
  Initial nonce: 1023
  Final nonce: 6187
  Total transactions mined: 5164 / 6000

❌ Combined load test with producer rotation FAILED
   Only 5164 out of 6000 transactions were mined
   Check /tmp/polycli_rotation_test.log for details
Cleaning up network latency...

findfluctuate avatar Dec 24 '25 02:12 findfluctuate

@kamuikatsurgi @pratikspatil024

Hi, Could you please review this PR at your convenience? Thank you very much.

It seems that the CI failure is unrelated to this change

  Progress: 3445/6000 transactions mined (120 seconds elapsed)
Load test still running after timeout, terminating...
Waiting 10 seconds for final transactions to settle...

=== Final Verification ===
Test results:
  Initial nonce: 1023
  Final nonce: 6187
  Total transactions mined: 5164 / 6000

❌ Combined load test with producer rotation FAILED
   Only 5164 out of 6000 transactions were mined
   Check /tmp/polycli_rotation_test.log for details
Cleaning up network latency...

Can you pull in the latest changes from develop?

kamuikatsurgi avatar Dec 24 '25 05:12 kamuikatsurgi