bor icon indicating copy to clipboard operation
bor copied to clipboard

StateDB interface changes

Open Rampex1 opened this issue 6 months ago • 1 comments

Description

Introduced Polygon-specific methods to the vm.StateDB interface Changed function signatures across many consensus engines to accept vm.StateDB instead of *state.StateDB

Changes

  • [ ] Bugfix (non-breaking change that solves an issue)
  • [ ] Hotfix (change that solves an urgent issue, and requires immediate attention)
  • [x] New feature (non-breaking change that adds functionality)
  • [ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • [ ] Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • [ ] I have added at least 2 reviewer or the whole pos-v1 team
  • [ ] I have added sufficient documentation in code
  • [ ] I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • [ ] Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • [ ] Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • [ ] This PR requires changes to heimdall
    • In case link the PR here:
  • [ ] This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • [ ] I have added unit tests
  • [ ] I have added tests to CI
  • [ ] I have tested this code manually on local environment
  • [ ] I have tested this code manually on remote devnet using express-cli
  • [ ] I have tested this code manually on amoy
  • [ ] I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

Rampex1 avatar Jun 27 '25 17:06 Rampex1

@maoueh

Rampex1 avatar Jun 27 '25 18:06 Rampex1

Relates to #1557

maoueh avatar Jul 08 '25 18:07 maoueh

Hi, thanks for attempting to fix the issue. I've found a more elegant and simple way to fix this following an approach similar to yours. Implemented in https://github.com/maticnetwork/bor/issues/1577.

manav2401 avatar Jul 09 '25 16:07 manav2401

@manav2401 I'll comment on the other PR, but it's not gonna work properly, explaining there.

maoueh avatar Jul 09 '25 20:07 maoueh

This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Aug 13 '25 00:08 github-actions[bot]

Closing this as https://github.com/0xPolygon/bor/pull/1623 is merged.

kamuikatsurgi avatar Aug 20 '25 12:08 kamuikatsurgi