bor icon indicating copy to clipboard operation
bor copied to clipboard

eth, miner: fix enforcing the minimum miner tip

Open pratikspatil024 opened this issue 2 years ago • 4 comments

  • eth, miner: fix enforcing the minimum miner tip

  • ethclient/simulated: fix failing test due the min tip change

  • accounts/abi/bind: fix simulater gas tip issue

Description

Cherry-picked geth#28933.

Changes

  • [ ] Bugfix (non-breaking change that solves an issue)
  • [ ] Hotfix (change that solves an urgent issue, and requires immediate attention)
  • [ ] New feature (non-breaking change that adds functionality)
  • [ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • [ ] Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • [ ] I have added at least 2 reviewer or the whole pos-v1 team
  • [ ] I have added sufficient documentation in code
  • [ ] I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • [ ] Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • [ ] Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • [ ] This PR requires changes to heimdall
    • In case link the PR here:
  • [ ] This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • [ ] I have added unit tests
  • [ ] I have added tests to CI
  • [ ] I have tested this code manually on local environment
  • [ ] I have tested this code manually on remote devnet using express-cli
  • [ ] I have tested this code manually on mumbai
  • [ ] I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

pratikspatil024 avatar Feb 07 '24 04:02 pratikspatil024

Codecov Report

Attention: Patch coverage is 46.15385% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 55.91%. Comparing base (08a2608) to head (2b28af5). Report is 289 commits behind head on develop.

Files Patch % Lines
miner/worker.go 47.05% 8 Missing and 1 partial :warning:
miner/miner.go 0.00% 3 Missing :warning:
eth/api_miner.go 0.00% 1 Missing :warning:
miner/test_backend.go 50.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1156      +/-   ##
===========================================
- Coverage    55.99%   55.91%   -0.08%     
===========================================
  Files          658      658              
  Lines       114455   114471      +16     
===========================================
- Hits         64087    64012      -75     
- Misses       46515    46609      +94     
+ Partials      3853     3850       -3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 07 '24 06:02 codecov[bot]

This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Feb 29 '24 00:02 github-actions[bot]

There are conflicts to be solved here

marcello33 avatar Mar 18 '24 09:03 marcello33

Yeah, this also needs to be tested on a devnet. Will take this up later this week.

pratikspatil024 avatar Mar 18 '24 09:03 pratikspatil024

Closing this in favour of PR#1209.

pratikspatil024 avatar Apr 05 '24 04:04 pratikspatil024