facerecognition icon indicating copy to clipboard operation
facerecognition copied to clipboard

Feature: Able to move between groups or remove recognized faces.

Open aleksandrmetik opened this issue 5 years ago • 12 comments

Hello Could you please implement action to move recognized faces between groups and/or remove from group? Thanks


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

aleksandrmetik avatar Aug 07 '19 08:08 aleksandrmetik

This is similar to #134 . This will require another "layer" on top of basic clustering (manual layer) and we are not sure how to do it correctly. Manual actions (join clusters, move/remove face to group) needs to be preserved once new clustering is executed. There is no plans to do it soon

stalker314314 avatar Aug 08 '19 06:08 stalker314314

Hi @aleksandrmetik, As Branko says, It is an expected feature of an application like this, and we have to do it right.

So, this will be for a second stage.. With enough external testing we must first ensure the stability of the clusters ... and seriously think about how to implement it.

matiasdelellis avatar Aug 13 '19 11:08 matiasdelellis

Hi @matiasdelellis,

for me a quick win would be to have the possibility in UI to untag (remove) single and complete groups of recognized faces completly from database, for two reasons:

  • When I reduce sensitivity the clustering works very well for all of my friends, but there are always a few wrong faces in the cluster but mainly "unknown" persons from background, which I never want to be tagged.
  • For doing lot of pictures at the performance of my band there are lot of pictures of audience which are recognized as well and I want to remove them as well. Because they slow down clustering process unnecessarily. The initial scan process of my round about 20000 pictures is finished for about 70% and there are already 25.000 faces recognized. I restart background scan process every 60 minutes with a timeout of 58 minutes. Reclustering takes already about 10 minutes of each run.

So I would request two feature:

  • Remove recognized faces single and bulk.
  • Requeue single picture for scanning, if I remove face accidentaly

DerOetzi avatar Jun 05 '20 07:06 DerOetzi

Hi @DerOetzi

Thank you very much for testing the application. :wink:

What I can tell you is that it is still under evaluation.
Now we have a simple database where to store the face encodings, and the clustering algorithm that gave us the best result keeping the application simple.

I am 95% sure that the wrong people in your main groups are unknown. But it doesn't mix two persons who are really important to you. If so, it is within current expectations.

I clarify and ask this, because one thing is remove a person that you do not care (A small hack), and another very different problem is to separate a group into two people (An important rewrite.)

Again, of course we have to improve, but I want to advance at the right step, and therefore I am thinking it through. That is, I don't want to do a little hack to add this feature, and then have to undo it because I found a better way or it causes problems.

This will take some time.. Sorry.

As for clustering speed, I don't know which PDlib you are using, but if not, try to recompile this https://github.com/matiasdelellis/pdlib

matiasdelellis avatar Jun 05 '20 13:06 matiasdelellis

Hi @matiasdelellis,

thanks for your fast reply. I understand the point on focusing on different aspects of stabilizing the app. What I don't understand why the requested feature should be a temporary hack? Maybe you can explain this a little bit more to me, because in my opinion the feature to remove recognized faces of unwanted or even unknown persons for example on crowdy places is a core feature of such application.

For clustering speed I use the Dockerfile example from the issue about docker integration, which uses https://github.com/goodspb/pdlib/archive/master.zip I can try this evening to reuse with your lib version.

I will start an PR and will try to make a suggestion for my feature request. Then you can have a look on it, whether this a hack. Maybe this will take a while, because I'm not familiar with nextcloud addon framework

DerOetzi avatar Jun 05 '20 14:06 DerOetzi

I second this feature. I have several incorrectly identified faces in groups - and I also additionally have one person split across multiple groups and would like them joined. I've tried fiddling with different sensitivity settings but to no avail.

HollowedEmpire avatar Jun 22 '20 22:06 HollowedEmpire

Hi @HollowedEmpire

I second this feature.

Ok.. At some point this feature will be developed. :wink:

I have several incorrectly identified faces in groups - and I also additionally have one person split across multiple groups and would like them joined. I've tried fiddling with different sensitivity settings but to no avail.

The quality of current algorithm is a balance between the least amount of errors in a group, and the least amount of groups of the same person. With high sensitivity, there will be few groups but of poor quality. With a low sensitivity, there will be many groups, but of great quality. I guess this is well documented.

Well, having this, it is relatively easy to join groups, but it is still difficult to separate these.

So the question is... With some configuration you have good quality groups? Regardless of the number of groups.

matiasdelellis avatar Jun 22 '20 23:06 matiasdelellis

Just commenting so I can follow this issue...looking forward to trying it out when an implementation is ready for testing.

Been playing with this plugin on my own pictures, and without the ability to "correct" the groupings, and move photos into the correct groupings / names, the results of running face recognition are too wrong for me currently.

darmbrust avatar Jul 23 '20 15:07 darmbrust

I made a mistake, I put to "to be checked" on different groups of people that I do not remember. But they were merged in 1 group "to be checked". Now there is no way to drop this group.

GAS85 avatar Jun 17 '21 08:06 GAS85

Hi @GAS85 Go to the photos of the person "to be checked", and see below that you must have a button that says "See groups of faces" 😉

matiasdelellis avatar Jun 17 '21 12:06 matiasdelellis

You make my day! Thanks that's works good!!!

GAS85 avatar Jun 29 '21 09:06 GAS85

I don't know how I can help with this, not knowing PHP or js (or web servers in general) very well, but I really need to be able to correct the name for a person. I keep having to reset and start over completely because I entered the wrong name for someone.

I'll help anyway I can.

guystreeter avatar Nov 11 '21 18:11 guystreeter

Hi, Although there may be improvements, this feature can be considered implemented. Some options are better to see in memories.

Thanks for everything!. 😄

matiasdelellis avatar Aug 24 '23 00:08 matiasdelellis