Mahtis Michel

Results 57 comments of Mahtis Michel

@char0n https://github.com/swagger-api/swagger-js/pull/2013/commits/2d715a1089cbe65372983f4095965685303f2f88#diff-4c3af2fb862ab7ff642af33fc7b839f031caf87d40fce8653ddce27261e89ad8R136-R139 like this?

fine then I proceed implementing guards for value and absolutify for the URL.

@ambition-consulting I have little time right now, but you are welcome to pick it up

@char0n Would it be ok to remove to resolved externalValue and place the resolved value in the `.value` path instead. If it should be placed in `.externalValue` how could this...

@char0n can try to finish this in the next week!

@char0n currently I am reading the OAS Spec 3.1.0, it is stating that [externalValue should follow the Relative References Section](https://spec.openapis.org/oas/v3.1.0#:~:text=are%20mutually%20exclusive.-,See%20the%20rules%20for%20resolving%20Relative%20References.,-This%20object%20MAY). This section states that it [should also resolve fragments](https://spec.openapis.org/oas/v3.1.0#:~:text=If%20a%20URI%20contains%20a%20fragment%20identifier%2C%20then%20the%20fragment%20should%20be%20resolved%20per%20the%20fragment%20resolution%20mechanism%20of%20the%20referenced%20document.%20If%20the%20representation%20of%20the%20referenced%20document%20is%20JSON%20or%20YAML%2C%20then%20the%20fragment%20identifier%20SHOULD%20be%20interpreted%20as%20a%20JSON-Pointer%20as%20per%20%5BRFC6901%5D.). 1....

@char0n have added the absolitfy for the url. No support for fragments until now. If needed please tell me. Needed to increase entrypoint size. Maybe we could refactor the absolitfy...

@char0n besides the review comment I made are there any changes need. I think the PR currently fulfills the stated behavior from your last comment.

[> If the file extension if different then `.json`, '.yaml`or`.yml`we should`base64 encode`the string before we transclude the resolved value to`value` field.](https://github.com/swagger-api/swagger-js/issues/1978#issuecomment-799476860) I think this is still missing,

Probably it is not good to base64 encode all other stuff. Imagine a external value that is a `.txt`, `.xml` or any other readable format. base64 does not make sense...