polymorphic_embed icon indicating copy to clipboard operation
polymorphic_embed copied to clipboard

Published 20 hours ago • verified publisher icon mathieuprog

Traverse nested PolymorphicEmbed errors

Open LouisMT opened this issue 2 years ago • 2 comments

It seems that traverse_errors/2 currently does not work, if the polymorphic_embeds_* is nested inside an Ecto-native *-to-one or *-to-many association. These errors are never processed.

This PR adds support for this.

Fixes #72

LouisMT avatar Mar 14 '23 14:03 LouisMT

I'm a bit confused because of this line in the project's README:

  • Support for nested embeds_one/embeds_many embeds

Does this mean that it should already support polymorphic_embeds_* nested in an embeds_*? Or is it the other way around?

If it's the other way around, I can update this PR to add support for nested embeds_one/embeds_many too.

LouisMT avatar Mar 14 '23 15:03 LouisMT

@mathieuprog is there any chance you could follow up on this PR? I'm running into the same issue. Thanks!

(Great work on the library btw)

Reinder1213 avatar Apr 12 '23 14:04 Reinder1213

This has been added. Awesome work. Sorry it took so much time. Couldn't merge as there were conflicts.

mathieuprog avatar May 26 '24 12:05 mathieuprog