Mathieu Decaffmeyer
Mathieu Decaffmeyer
Can I see your code? Ie how you call `Form.get_polymorphic_type` ? Because this piece of code has been added by a contributor, I am not using it personally, and it'd...
This has been added. Awesome work. Sorry it took so much time. Couldn't merge as there were conflicts.
Hello. The most blocking PRs have been addressed.
This is now supported. @SteffenDE all your changes from your branch have been added. Awesome work.
@SteffenDE btw, basic question as I'm not a LiveView user, the equivalent of `PolymorphicEmbed.HTML.Component.polymorphic_embed_inputs_for/1`, which you added, is `Phoenix.Component.inputs_for/1` in LiveView. But where is the equivalent for `polymorphic_embed_inputs_for/2` (from the...
Thank you. So `polymorphic_embed_inputs_for/2` function is to be removed then?https://github.com/mathieuprog/polymorphic_embed/blob/master/lib/polymorphic_embed/html/form.ex#L44 ? It was specifically added for LiveView.
Actually it seems that all the `_inputs_for` functions defined in HTML.Form are obsolete? https://github.com/mathieuprog/polymorphic_embed/blob/master/lib/polymorphic_embed/html/form.ex Do we even still need this module at all?
Thanks woylie. On my side I don't have a codebase with form rendering to test such changes. If anyone could clean up the unnecessary functions/modules and update the readme, that'd...
@woylie @SteffenDE Could you have a look at this? https://github.com/mathieuprog/polymorphic_embed/issues/101 Could you share me your opinion on the package name?