timezone-butler icon indicating copy to clipboard operation
timezone-butler copied to clipboard

Published 20 hours ago • verified publisher icon mathieudutour

Butler showing conversion for 0PM as part of a user's ID

Open phoutekier-issa opened this issue 1 year ago • 3 comments

Describe the bug After a new user was added to our slack, the Timezone Butler started displaying timezone conversions anytime he was tagged even when there was no time in the actual message. I believe that the character '0PM' appear in this user's ID.

To Reproduce Steps to reproduce the behavior:

  1. Go to any slack channel with Timezone Butler
  2. Say '0PM'
  3. Other users will see timezone conversions for the nonsensical 0PM.

Expected behavior No Timezone Butler conversion should occur when XPM or XAM is found in a user's ID as part of a tag

Screenshots image

Additional context In the screenshot, the middle welcome message is from somebody in the same time zone and me, so there was no conversion.

phoutekier-issa avatar Jun 14 '23 18:06 phoutekier-issa

We've got same issue for user with id that contains 1AM

dmk1111 avatar Dec 14 '23 09:12 dmk1111

Any update on this one?

dima-supy-io avatar Dec 28 '23 11:12 dima-supy-io

Happy to merge a PR fixing this bug

mathieudutour avatar Jan 11 '24 11:01 mathieudutour