timezone-butler
timezone-butler copied to clipboard
mathieudutour
5PM is 6pm in your timezone, except that's not true
Describe the bug I'm located in FL, ET. The post was 5PM ET but the person posting it was in Central time, so timezone butler said it's 6pm. My timezone is set to UTC -5, Eastern Time.
To Reproduce Steps to reproduce the behavior:
- Send a message to the channel with a time
- Timezone butler gives a wrong time translation
Expected behavior Can't timezone butler say timezones to make it clear? "5pm ET is 6pm CST" instead of 5pm is 6pm.
Screenshots See screenshot here: https://drive.google.com/file/d/1ekooGPUxaZOm5PgNa6UECH377dZDF3HW/view?usp=sharing
guessing this was never resolved since we just got the app and it had wrong timezone for one of us. :/
We see a similar issue. The app apparently does not use any timezone specified in the message, but only the timezones of the message poster and viewer (as per their slack preferences).
For example, a user in USA ET posted this message which I saw in USA PT: "Starting at 15:00 UTC on 2023-08-16" and the app posts: "15:00 UTC is noon in your timezone."
This is a correct translation of 15:00 ET to 12:00 PT, but not 15:00 UTC to what should be 8:00 PT. So it looks like the app is not reading timezones from the message.
If the app at least included the timezones it was translating, it might be a bit less confusing, but then it might say something like: "15:00 UTC ET is noon PT in your timezone."
Ideally the app would recognize the timezone supplied in the message and use that to translate, rather than the timezone setting of the message poster.
It should understand timezones, there are tests for it: https://github.com/mathieudutour/timezone-butler/blob/develop/bot/tests/timezones.test.ts#L82
Maybe you can add a test case to see when it's not recognised?
I'm running into this same issue and reached out to Slack support because I'm in MST (UTC-7) but right now we're in MDT (UTC-6). Slack shows my timezone as Mountain (UTC-7) and the support agent says they calculate the daylight savings offset elsewhere (IOW the timezone picker always shows the standard TZ offset). Assuming TZ Butler is using my Slack timezone setting (UTC-7) and relying on Slack to handle the daylight savings offset, this makes sense the time it reports 1hr off for me.
