timezone-butler icon indicating copy to clipboard operation
timezone-butler copied to clipboard

Butler interprets "12:xxpm" as midnight hour, doesn't recognize 'noon' at all

Open dgpokl opened this issue 6 years ago • 4 comments

Describe the bug Butler interprets "12:00pm" as midnight. While some might point out that 12:00 is technically neither AM nor PM, computers treat AM as midnight and PM as noon and many people do the same. Plus the behavior is straight-up incorrect for times including 12:01PM-12:59PM, which are not ambiguous at all but are interpreted as though they're 12:01-12:59 AM.

Interestingly you can just type 12:00 by itself and it will interpret that as noon. Not sure what to type right now to get midnight.

To Reproduce Steps to reproduce the behavior:

  1. Type "12:00pm" in a New York time zone
  2. User in Los Angeles sees "12:00pm is 9pm in your timezone." and:
  3. Type "12:01pm" in a New York time zone
  4. User in Los Angeles sees "12:01pm is 9:01pm in your timezone." and:
  5. Type "noon" or "midnight"
  6. Nothing happens

Expected behavior Butler should treat 12:xx AM as the hour that comes before 01:00 AM Butler should notice the two keywords noon and midnight.

dgpokl avatar Jan 14 '19 17:01 dgpokl

Agree! Please fix this 🙏🏾

hacker-DOM avatar Jun 03 '19 08:06 hacker-DOM

12pm = noon. Ideally there would be an optional to set either, but I second that noon is most people's interpretation in my experience

hacker-DOM avatar Jun 03 '19 08:06 hacker-DOM

I know it's been over a year, but I just found this repo. Would 00:00 work for midnight? That's how it's represented in 24-hr time.

michaeldunnjr avatar Oct 01 '20 14:10 michaeldunnjr

also experienced this issue.

stephen-apto avatar May 18 '21 17:05 stephen-apto

should be fixed now

mathieudutour avatar Jan 23 '23 09:01 mathieudutour