github-tag-action icon indicating copy to clipboard operation
github-tag-action copied to clipboard

Keywords not parsed in commit message

Open d3ssy opened this issue 2 years ago • 7 comments

Using both the default angular based syntax (e.g. feat: my feature summary) and custom keywords (e.g. FEATURE:minor) in the action inputs does not trigger the appropriate bump in the version, only the default patch bump. I've tried using "fix:", "fix(scope):, etc., but none of them seem to work.

Any ideas where i'm going wrong here?

Run mathieudutour/[email protected]
with:
    github_token: ***
    custom_release_rules: MAJOR:major,MINOR:minor,PATCH:patch, FIX:patch, BUG:patch, FEATURE:minor
    default_bump: patch
    tag_prefix: v
    release_branches: master,main
    create_annotated_tag: false
    fetch_all_tags: false
    dry_run: false

Previous tag was v0.1.16, previous version was 0.1.16.
Analyzing commit: Update Build_Prerelease_Deploy.yml

FEATURE: Test bump
The commit should not trigger a release
Analysis of 1 commits complete: no release
New version is 0.1.17.
New tag after applying prefix is v0.1.17

d3ssy avatar Jul 31 '21 10:07 d3ssy

It might be because you have a space before FEATURE:minor

mathieudutour avatar Aug 02 '21 06:08 mathieudutour

It might be because you have a space before FEATURE:minor

Does not seem to trigger with any commit msg, standard or custom. What to do?

Run mathieudutour/[email protected] with: github_token: *** custom_release_rules: MAJOR:major,MINOR:minor,PATCH:patch,FIX:patch,BUG:patch,FEATURE:minor default_bump: patch tag_prefix: v release_branches: master,main create_annotated_tag: false fetch_all_tags: false dry_run: false

Previous tag was v0.1.18, previous version was 0.1.18. Analyzing commit: Update Build_Prerelease_Deploy.yml

FEATURE:Test release trigger minor version The commit should not trigger a release Analysis of 1 commits complete: no release New version is 0.1.19. New tag after applying prefix is v0.1.19. Changelog is ### 0.1.19 (2021-08-04)

d3ssy avatar Aug 04 '21 00:08 d3ssy

Hi there, is action still working? I m testing it but I also cannot bum any version that is not patch, tried several ways to configure the custom_release_rules, but none of them have worked for me. any example how to use it aside from what is on the readme?

sircurse avatar Aug 06 '22 01:08 sircurse

Hi there, Even am facing issue. Only patch version is getting generated. Below the github workflow snippet

- name: Bump version and push tag
  id: tag_version
  uses: mathieudutour/[email protected]
  with:
    github_token: ${{ secrets.github-token }}
    pre_release_branches: development,stage
    default_prerelease_bump : patch
    release_branches: main
    custom_release_rules: "Bug:patch:Bug Fix,Config:minor:Configuration Changes,Revert:patch:Changes Reverted,Docs:patch:Document Changes,Feature:minor:New Feature,Breaking Change:major:BREAKING CHANGE!!!,CICD:minor:CICD Changes,Monitoring:minor:Monitoring Changes,Major:major:Major Change"

Please let me know if I missed anything.

Adding to the custom release rules. I referred the document (https://github.com/mathieudutour/github-tag-action#bumping) and tried below two commit messages.

feat(pencil): add 'graphiteWidth' option

perf(pencil): remove graphiteWidth option

But both the commit messages generated a patch version.

Thanks, Marshall

marshall-kiruba-selwyn avatar Sep 29 '22 16:09 marshall-kiruba-selwyn

I had the same issue. Supposedly, you have to use the exact wording, as described in the README:

fix(pencil):
feat(pencil):

etc

See my logs:

Just using fix, feat etc in the commit message:

Analyzing commit: Fix code docs
The commit should not trigger a release
Analyzing commit: fix✏️: Added missing `_init()` in `EventContentsCollection.gd` to specify `_item_type`. Otherwise, deserialization would fail.
The commit should not trigger a release
Analyzing commit: feat➕: Add Default Theme (#64)

* Add Theme file
* Added new default theme
The commit should not trigger a release
Analyzing commit: fix ✏️: Login with incorrect credentials stalls the demo #76 (#77)
The commit should not trigger a release
Analyzing commit: 55 update documentation (#78)

* Improved generic request example
* Fix✏️: events docs
The commit should not trigger a release
Analyzing commit: Update demo scene gif (#80)
The commit should not trigger a release
Analyzing commit: Fix demo scene file
The commit should not trigger a release
Analyzing commit: Patch Issue #81 (#82)

Fix: Anonymous Login button does not turn green after successful anonymous login

Making the button green which is currently logged in

Co-authored-by: Johannes Ebner <[email protected]>
The commit should not trigger a release
Analysis of 8 commits complete: no release

Exact usage of feat(pencil)

Run mathieudutour/[email protected]
Previous tag was 0.1.0, previous version was 0.1.0.

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/[20](https://github.com/Structed/godot-playfab/actions/runs/3517792328/jobs/5895970415#step:3:21)[22](https://github.com/Structed/godot-playfab/actions/runs/3517792328/jobs/5895970415#step:3:23)-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Analyzing commit: fix(pencil): fix code docs
The release type for the commit is patch
Analyzing commit: fix(pencil): Added missing `_init()` in `EventContentsCollection.gd` to specify `_item_type`. Otherwise, deserialization would fail.
The release type for the commit is patch
Analyzing commit: feat(pencil): Add Default Theme (#64)

* Add Theme file
* Added new default theme
The release type for the commit is minor
Analyzing commit: fix(pencil): Login with incorrect credentials stalls the demo #76 (#77)
The release type for the commit is patch
Analyzing commit: fix(pencil): 55 update documentation (#78)

* Improved generic request example
* Fix✏️: events docs
The release type for the commit is patch
Analyzing commit: fix(pencil): Update demo scene gif (#80)
The release type for the commit is patch
Analyzing commit: fix(pencil): Fix demo scene file
The release type for the commit is patch
Analyzing commit: fix(pencil): Anonymous Login button does not turn green after successful anonymous login #81 (#82)

Making the button green which is currently logged in

Co-authored-by: Johannes Ebner <[email protected]>
The release type for the commit is patch
Analysis of 8 commits complete: minor release

Structed avatar Nov 21 '22 20:11 Structed

Figured out how to use custom_release_rules:

      - name: Calculate version
        id: calculate_version
        uses: mathieudutour/[email protected]
        with:
          tag_prefix: ""
          github_token: ${{ secrets.GITHUB_TOKEN }}
          dry_run: true
          default_bump: false
          custom_release_rules: |
            "fix:patch:Bug Fixes,hotfix:patch:Bug Fixes,feature:minor:Features,change:minor:Changes,breaking:major:Breaking Changes,major:major:Major Changes"

You then have to start your commit message with the keyword, followed by a colon.

Examples:

  • fix: this is a hotfix
  • breaking: Big API changes

Structed avatar Jan 22 '23 00:01 Structed

Just incase anyone has had the same silly understanding as I had,

If you are using a graphical tool like Github for Windows, the feat(something): whatever needs to go in your commit summary, not the description, otherwise it won't be the first thing in the commit message.

PaulDevenney avatar Sep 26 '23 10:09 PaulDevenney