github-tag-action icon indicating copy to clipboard operation
github-tag-action copied to clipboard

Published 20 hours ago • verified publisher icon mathieudutour

`feat!: some breaking change` format isn't working

Open chrisjohnson00 opened this issue 3 years ago • 1 comments

Spec number 13 from https://www.conventionalcommits.org/en/v1.0.0/:

If included in the type/scope prefix, breaking changes MUST be indicated by a ! immediately before the :. If ! is used, BREAKING CHANGE: MAY be omitted from the footer section, and the commit description SHALL be used to describe the breaking change.

However, using feat! as a prefix, results in a PATCH release, not a MAJOR

Tried using a custom prefix mapping, but the expressions used to parse it seems to be dropping it due to the ! and still resulted in a patch release.

I understand that this action is based off Angular's convention... so if you feel it's out of scope to make this change, I won't fight you :P

chrisjohnson00 avatar Apr 22 '21 23:04 chrisjohnson00

I'm all for making the custom mapping more robust and powerful.

Happy to accept a PR to work towards that!

mathieudutour avatar Apr 23 '21 06:04 mathieudutour