Mathieu Dutour

Results 272 comments of Mathieu Dutour

The algorithm is pretty much the same: ``` fn1: - enumerate the symbol instances in the container - for each symbol instance - fn2 - for each symbol override, fn2...

would it be possible to for you to invite me to the repo so that I can reproduce?

If I understand correctly, you mean that it show some changed files, not that it creates a commit?

So yes, that's not a commit, that's just showing the current changed files until Kactus re-generate the sketch file. This is a bit weird and I haven't seen this behaviour...

Hum hard to say what's happening. Can you make sure there is a `document.json` file in the `employee order 3.0` folder?

That's the reason why it doesn't appear on their machine then, Kactus needs a document.json to recreate the file. Now the question is: why didn't it create the document.json file....

No I've seen some repo with 25 sketch files haha I'll try to reproduce

maybe something like this: ![pr view](https://user-images.githubusercontent.com/3254314/28208655-b9032aaa-6886-11e7-942a-73f2928ec7bb.png)

later on, we could even select an area on the visual diff and add a comment (using the github API and a special format to specify the area). The comments...