license-maven-plugin icon indicating copy to clipboard operation
license-maven-plugin copied to clipboard

Support ignore the year check

Open Leo6Leo opened this issue 1 year ago • 7 comments

Describe the feature If we don't pass in the variable, then don't check the year.

<plugin>
        <groupId>com.mycila</groupId>
        <artifactId>license-maven-plugin</artifactId>
        <version>${mycila.license.plugin.version}</version>
        <configuration>
          <licenseSets>
            <licenseSet>
              <header>com/mycila/maven/plugin/license/templates/APACHE-2.txt</header>
              <includes>
                <include>src/**/*.java</include>
              </includes>
              <excludes>
                <exclude>**/DataPlaneContract.java</exclude>
              </excludes>
            </licenseSet>
          </licenseSets>
          <properties>
            <owner>Authors</owner>
            <email>[email protected]</email>
            <year>2018</year>
          </properties>
        </configuration>
        <executions>
          <execution>
            <id>check-license</id>
            <goals>
              <goal>check</goal>
            </goals>
            <phase>verify</phase>
          </execution>
        </executions>
      </plugin>

Any alternative you've considered ?

A clear and concise description of any alternative solutions or features you've considered.

Same for other variables, like if we don't pass email, then won't check email.

Leo6Leo avatar Aug 14 '23 16:08 Leo6Leo

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Oct 13 '23 20:10 stale[bot]

keep open

hazendaz avatar Oct 17 '23 23:10 hazendaz

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Dec 17 '23 10:12 stale[bot]

keep open

Leo6Leo avatar Dec 17 '23 14:12 Leo6Leo

I wrote some initial code in #323 attempting to address my request #309. It may be useful for anyone wanting to implement this.

dbwiddis avatar Dec 18 '23 05:12 dbwiddis

Thanks @dbwiddis , I reopened that one. I really dislike the stale bot, most of us don't have time to address everything so fast and things get lost otherwise.

hazendaz avatar Dec 18 '23 07:12 hazendaz

There could be a lot of issues like this implemented with better "tokenization" of the header.

And we could definitely increase the timeout time on the stale bot to much longer. The fact that the majority of emails I get from this repo are from stale bot indicate that very little new code is being written, people want features but don't want to contribut the code for them, and the maintainers are overtasked elsewhere. :(

dbwiddis avatar Dec 18 '23 07:12 dbwiddis

@Leo6Leo :

  • if the year is not important to you, please choose another template with a year that is fixed in the template. com/mycila/maven/plugin/license/templates/APACHE-2.txt required a year to be fed

  • if you need to handle years properly, use the git plugin to source the year range from the files

  • If you want to create your own rules about what to check or not based on properties, use Mavan mechanism like profiles, or MLP license sets

mathieucarbou avatar May 12 '24 07:05 mathieucarbou