Mathieu Boudreau, PhD
Mathieu Boudreau, PhD
Hi @hermancollin - what's the state of this PR, and where should I focus my efforts to help you get this to the finish line? > It would be nice...
@hermancollin re: failing windows tests, I've narrowed down the issue to being caused by `import torch` in the apply model. If it's commented out, it runs the tests, but if...
> Torch isn't being installed by us explicitly, but implicitly by IVADOMED: https://github.com/ivadomed/ivadomed/blob/1fccf77239985fc3be99161f9eb18c9470d65206/requirements.txt#L22-L23 > > I'm wondering if restricting torch to < 2.4.0 could work; it would also be interesting...
Could be related to this: https://github.com/pytorch/pytorch/issues/131958
Looks like [68401af](https://github.com/axondeepseg/axondeepseg/pull/800/commits/68401af6edf7f7c8160e4f593409417ed2db8346) did the trick, I'll keep an eye out on if/when Torch fixes this Windows bug
@hermancollin just a heads up, I'm trying to run the tests on my mac, and all the ones that run the segmentation are error-ing out due to a segmentation fault....
> no I'm not on ARM and the mac on which I tested this PR was an old intel imac. > > are the github tests only on intel macos?...
@hermancollin I think we just need your approval to merge this PR - the tests all passed - although, this was pre-numpy 2.x, so I'm going to rerun them just...
Ha glad I rechecked, will look into this
Ah it's not numpy, but coveralls, ``` Traceback (most recent call last): File "/usr/share/miniconda/envs/ads_venv/lib/python3.8/site-packages/coveralls/cli.py", line 98, in main result = coverallz.wear() File "/usr/share/miniconda/envs/ads_venv/lib/python3.8/site-packages/coveralls/api.py", line 275, in wear return self.submit_report(json_string) File...