Mathias Rasmussen

Results 59 comments of Mathias Rasmussen

> Can you explain further? I don't see an easy way to access the video dom element from the SubtitlesController (or determine when it's created). Also we are currently parsing...

Related issue https://github.com/electron/electron/issues/17972. Seems like this should be handled in `electron-installer-debian`, but does not work for Electron 6? @carlosnewmusic For now, you have to run webtorrent-desktop with the `--no-sandbox` flag,...

I think webtorrent checks this when starting a torrent?

It would be nice if we could use the [HTMLMediaElement.audioTracks](https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/audioTracks) property, but it isn't widely supported yet. Here is an issue tracking it for chromium https://bugs.chromium.org/p/chromium/issues/detail?id=249427.

I think combining `bounds` and `isMaximized` in your first option is a good idea. Does the resize/move events fire when maximizing/unmaximizing the window? Otherwise we probably need the maximize event....

I think the easiest way to do this is with [app.dock.setIcon()](https://electronjs.org/docs/api/app#appdocksetmenumenu-macos).

@jbucaran Seems like it only works for tag content and not attributes?

I wanted to make the code more consistent by not using multiple abs functions. An alternative is to use the ABS macro everywhere instead but I would much prefer to...

@etracer65 It's not an assumption but a simple observation of how floats are usually handled with DEBUG_SET. I made this notice exactly for people to take these cases into consideration....

> It is not true that the `DEBUG_SET` statements **_usually_** use `lrintf` or that there's some requirement that they do. Out of the 68 cases where DEBUG_SET is called with...